Closed
Bug 1744316
Opened 3 years ago
Closed 3 years ago
Replace nsILocalFileWin::{Get,Set}FileAttributesWin with nsILocalFileWin::{Get,Set}ReadOnly
Categories
(Core :: XPCOM, task)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
97 Branch
| Tracking | Status | |
|---|---|---|
| firefox97 | --- | fixed |
People
(Reporter: beth, Assigned: beth)
Details
Attachments
(1 file)
The only usage of FileAttributesWin in tree are getting and setting readonly bits.
|
Assignee | |
Comment 1•3 years ago
|
||
This replaces the under-used FileAttributes attribute with a ReadOnly
attribute, since that is the only Windows file attribute that was being
toggled. This attribute is only used in tests to simulate lack of writing
permissions to certain files.
Depends on D133832
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d14261ebd3b1
Replace nsILocalFileWin::FileAttributes with ::ReadOnly r=nika,application-update-reviewers,nalexander
|
||
Comment 3•3 years ago
|
||
Backed out 2 changesets (Bug 1744809, Bug 1744316) for causing xpcshell failures on marAppApplyDirLockedStageFailure_win.js.
Backout link
Push with failures
Failure Log
Flags: needinfo?(brennie)
|
|
Assignee | |
Updated•3 years ago
|
Flags: needinfo?(brennie)
|
|
Assignee | |
Comment 4•3 years ago
|
||
Missed a usage of fileAttributesWin
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0973c2b6c3c0
Replace nsILocalFileWin::FileAttributes with ::ReadOnly r=nika,application-update-reviewers,nalexander
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox97:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•