1744346 - Use MediaDevice mID and mRawID fields consistently

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, task, P1)

Description

[Karl Tomlinson (:karlt)]

Currently, sometimes mID contains a raw id and sometimes an anonymized id.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: Bug 1744346 consolidate boolean device enumeration parameters into a flags parameter r?jib

The key motivator here was the misleading aForceNoPermRequest parameter.
This came from an unreviewed change in response to a review request.
https://phabricator.services.mozilla.com/D14575?vs=44463&id=47352#inline-82282
The newer variable name described the opposite of its use, but its usage was
not negated.

The logical change to the AllowPermissionRequest flag no longer passed from
MediaDevices::GetSinkDevice() has little effect because any permission
required would be obtained from getUserMedia() or selectAudioOutput() prior to
setSinkId(). A permission request is not expected during setSinkId().

The EnumerateAudioOutputs flag removes some use of the confusing
MediaSinkEnum::Other and makes the long list of parameters slightly easier to
read.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1744346 use nsIMediaSource.rawId to initialize PermissionDelegate.MediaSource.id r?agi

and use nsIMediaSource.rawId to initialize the id field.

rawId is otherwise unused in GeckoView and Android Components.

GeckoView uses MediaSource.id simply as a unique identifier to find associated
nsIMediaSource objects.

Android Components uses MediaSource.id simply as a unique identifier to find
a MediaSource from an associated Permission object.
https://searchfox.org/mozilla-mobile/rev/2df7441e996a8e4adfc25a2190415d50f6cf810a/android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/permission/GeckoPermissionRequest.kt#137
id is not used when storing the permission.
https://searchfox.org/mozilla-mobile/rev/2df7441e996a8e4adfc25a2190415d50f6cf810a/android-components/components/feature/sitepermissions/src/main/java/mozilla/components/feature/sitepermissions/SitePermissionsFeature.kt#643-648

Use of nsIMediaSource.rawId is consistent with Firefox for Desktop.
https://searchfox.org/mozilla-central/rev/0998b61022a1ece43afe3c750077e5804c6c6392/browser/actors/WebRTCChild.jsm#324

This will permit removal of nsIMediaSource.id which is otherwise unused.

Depends on D132875

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1744346 test that the mochitest window is among the scary r?jib

Depends on D132876

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: Bug 1744346 remove unused nsIMediaDevice properties r?jib

Depends on D132877

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: Bug 1744346 remove unused raw MediaDevice constructor parameter aRawID r?jib

This may have been unused since a different constructor was added for AnonymizeDevices() in
https://hg.mozilla.org/mozilla-central/rev/d4d476a32ea823ee98a40bedbcdd509dee5dc84c#l3.256

Depends on D132878

Comment 6

[Karl Tomlinson (:karlt)]

Attachment: Bug 1744346 simplify MediaDevice group id changes r?jib

Depends on D132879

Comment 7

[Karl Tomlinson (:karlt)]

Attachment: Bug 1744346 remove unused AnonymizeDevices path for empty aOriginKey r?jib

AnonymizeDevices() will not be called if GetPrincipalKey() rejects.
https://searchfox.org/mozilla-central/rev/5c35d0f53fbd1b8b992d192cb5239bf2cc3e6e6e/dom/media/MediaManager.cpp#2999

Depends on D132880

Comment 8

[Karl Tomlinson (:karlt)]

Attachment: Bug 1744346 consistently store raw MediaDevice ids and name in raw fields r?jib

to clarify which data is used by getters.

Depends on D132881

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8897871c71e
use nsIMediaSource.rawId to initialize PermissionDelegate.MediaSource.id r=agi

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f8897871c71e

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/020a55212036
consolidate boolean device enumeration parameters into a flags parameter r=jib
https://hg.mozilla.org/integration/autoland/rev/66269278654b
test that the mochitest window is among the scary r=jib
https://hg.mozilla.org/integration/autoland/rev/3a48eec2115a
remove unused nsIMediaDevice properties r=jib
https://hg.mozilla.org/integration/autoland/rev/7aae55aeb724
remove unused raw MediaDevice constructor parameter aRawID r=jib
https://hg.mozilla.org/integration/autoland/rev/913d8b936920
simplify MediaDevice group id changes r=jib
https://hg.mozilla.org/integration/autoland/rev/f37ffa0cae82
remove unused AnonymizeDevices path for empty aOriginKey r=jib

Comment 12

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/020a55212036
https://hg.mozilla.org/mozilla-central/rev/66269278654b
https://hg.mozilla.org/mozilla-central/rev/3a48eec2115a
https://hg.mozilla.org/mozilla-central/rev/7aae55aeb724
https://hg.mozilla.org/mozilla-central/rev/913d8b936920
https://hg.mozilla.org/mozilla-central/rev/f37ffa0cae82

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/504c4fa4291c
consistently store raw MediaDevice ids and name in raw fields r=jib

Comment 14

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/504c4fa4291c