1744397 - Simplify refresh code

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Bug 1744397 - Simplify refresh code: remove aRepeat argument. r?smaug!

Depends on D132837

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: Bug 1744397 - Simplify refresh code: remove aMetaRefresh argument. r?smaug!

Depends on D132860

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: Bug 1744397 - Simplify refresh code: clean up meta refresh code in nsDocShell. r?smaug!

Depends on D132861

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: Bug 1744397 - Simplify refresh code: pass around delay as an unsigned int. r?smaug!

Depends on D132862

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e7755177481
Simplify refresh code: remove aRepeat argument. r=smaug
https://hg.mozilla.org/integration/autoland/rev/634641e3a05a
Simplify refresh code: remove aMetaRefresh argument. r=smaug
https://hg.mozilla.org/integration/autoland/rev/41abd4b7d2c0
Simplify refresh code: clean up meta refresh code in nsDocShell. r=smaug
https://hg.mozilla.org/integration/autoland/rev/7b01edc5a0e0
Simplify refresh code: pass around delay as an unsigned int. r=smaug

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing wpt failures on attr-meta-http-equiv-refresh/parsing.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/49e1c067ecf7477a49c3efeb9b6196c44417a476

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7b01edc5a0e037508da8ccd2f37df4e5091f3b3a&selectedTaskRun=HMef7vizSfKqEb7xwKLtHg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=361164527&repo=autoland&lineNumber=7208

Failure line: TEST-UNEXPECTED-PASS | /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html?101-110 | Refresh header: "-0; foo" - expected FAIL // TEST-UNEXPECTED-PASS | /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html?101-110 | <meta>: "-1" - expected FAIL

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82460ab56adb
Simplify refresh code: remove aRepeat argument. r=smaug
https://hg.mozilla.org/integration/autoland/rev/ff8141e8c7ee
Simplify refresh code: remove aMetaRefresh argument. r=smaug
https://hg.mozilla.org/integration/autoland/rev/2d6b6100adb6
Simplify refresh code: clean up meta refresh code in nsDocShell. r=smaug
https://hg.mozilla.org/integration/autoland/rev/1afbd51ce081
Simplify refresh code: pass around delay as an unsigned int. r=smaug

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/82460ab56adb
https://hg.mozilla.org/mozilla-central/rev/ff8141e8c7ee
https://hg.mozilla.org/mozilla-central/rev/2d6b6100adb6
https://hg.mozilla.org/mozilla-central/rev/1afbd51ce081