Closed
Bug 1744473
Opened 2 years ago
Closed 2 years ago
Add null-check after ExtensibleCompilationStencil allocation
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
97 Branch
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox95 | --- | unaffected |
firefox96 | --- | fixed |
firefox97 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta+
|
Details | Review |
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Keywords: regression
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/f7e7b11c712e Add null-check after ExtensibleCompilationStencil allocation. r=nbp
Comment 3•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox97:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
Updated•2 years ago
|
status-firefox95:
--- → unaffected
status-firefox96:
--- → affected
status-firefox-esr91:
--- → unaffected
Comment 4•2 years ago
|
||
The patch landed in nightly and beta is affected.
:arai, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Flags: needinfo?(arai.unmht)
Assignee | ||
Comment 5•2 years ago
|
||
Comment on attachment 9253785 [details]
Bug 1744473 - Add null-check after ExtensibleCompilationStencil allocation. r?nbp!
Beta/Release Uplift Approval Request
- User impact if declined: crash on out of memory
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Adds fallback path for out of memory.
the fallback path is also taken by other failure path. - String changes made/needed:
Flags: needinfo?(arai.unmht)
Attachment #9253785 -
Flags: approval-mozilla-beta?
Comment 6•2 years ago
|
||
Comment on attachment 9253785 [details]
Bug 1744473 - Add null-check after ExtensibleCompilationStencil allocation. r?nbp!
Approved for 96.0b3
Attachment #9253785 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•2 years ago
|
||
bugherder uplift |
Updated•2 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•