1744473 - Add null-check after ExtensibleCompilationStencil allocation

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

https://searchfox.org/mozilla-central/rev/3407e72ceb5039da514c03ae61bd279b1725c3b2/js/src/frontend/BytecodeCompiler.cpp#893-901

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1744473 - Add null-check after ExtensibleCompilationStencil allocation. r?nbp!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7e7b11c712e
Add null-check after ExtensibleCompilationStencil allocation. r=nbp

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f7e7b11c712e

Comment 4

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:arai, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Tooru Fujisawa [:arai]]

Comment on attachment 9253785 [details]
Bug 1744473 - Add null-check after ExtensibleCompilationStencil allocation. r?nbp!

Beta/Release Uplift Approval Request

• User impact if declined: crash on out of memory
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds fallback path for out of memory.
  the fallback path is also taken by other failure path.
• String changes made/needed:

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9253785 [details]
Bug 1744473 - Add null-check after ExtensibleCompilationStencil allocation. r?nbp!

Approved for 96.0b3

Comment 7

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8c6b49ea12fd