1744582 - Intermittent GeckoProfiler.CPUUsage | Expected: (threadCPUDeltaZeroCount) > (0u), actual: 0 vs 0

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: apavel [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=360274761&repo=mozilla-beta
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/DSHWFh0SQ3KZIBMmgTq6KA/runs/0/artifacts/public/logs/live_backing.log

---

[task 2021-12-06T19:08:55.581Z] 19:08:55     INFO -  TEST-START | GeckoProfiler.CPUUsage
[task 2021-12-06T19:08:55.637Z] 19:08:55  WARNING -  TEST-UNEXPECTED-FAIL | GeckoProfiler.CPUUsage | Expected: (threadCPUDeltaZeroCount) > (0u), actual: 0 vs 0
[task 2021-12-06T19:08:55.637Z] 19:08:55     INFO -  There should be some zero-CPUs due to the idle loop body @ /builds/worker/checkouts/gecko/tools/profiler/tests/gtest/GeckoProfiler.cpp:4341
[task 2021-12-06T19:08:55.701Z] 19:08:55  WARNING -  TEST-UNEXPECTED-FAIL | GeckoProfiler.CPUUsage | test completed (time: 121ms)
[task 2021-12-06T19:08:55.701Z] 19:08:55     INFO -  TEST-START | GeckoProfiler.AllThreads

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1744582 - Rework GeckoProfiler.CPUUsage idle/busy expectations - r?canaltinova

First, add the "Busy test" thread to the filters, so it actually get sampled!
Also check that each expected thread is present (this is how the above error was found).

And instead of expecting some zeroes/non-zeroes in idle/busy threads, which can unfortunately intermittently fail, just add up the CPU values for each thread, and we should at least expect that the busy thread will have done more work than the idle thread.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a09f76aa6703
Rework GeckoProfiler.CPUUsage idle/busy expectations - r=canaltinova

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a09f76aa6703

Comment 4

[Intermittent Failures Robot]

9 failures in 3319 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 2
• autoland: 5
• mozilla-central: 2

Platform and build breakdown:

• linux1804-64-shippable-qr: 3
  • opt: 3
• linux1804-64-qr: 5
  • opt: 3
  • debug: 2
• linux1804-32-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1744582&startday=2021-12-06&endday=2021-12-12&tree=all

Comment 5

[Intermittent Failures Robot]

1 failures in 3263 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform and build breakdown:

• linux1804-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1744582&startday=2021-12-13&endday=2021-12-19&tree=all