1744665 - "UnboundLocalError: local variable 'rv' referenced before assignment" in python/mach/mach/logging.py

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P1)

Description

[Dão Gottwald [:dao]]

I got this error when trying to build on Ubuntu 21.10:

UnboundLocalError: local variable 'rv' referenced before assignment

  File "/home/dao/mozilla/unified/python/mozbuild/mozbuild/build_commands.py", line 220, in build
    return driver.build(
  File "/home/dao/mozilla/unified/python/mozbuild/mozbuild/controller/building.py", line 1106, in build
    if self._check_clobber(self.mozconfig, os.environ):
  File "/home/dao/mozilla/unified/python/mozbuild/mozbuild/controller/building.py", line 1745, in _check_clobber
    self.log(logging.WARNING, "clobber", {"msg": line.rstrip()}, "{msg}")
  File "/home/dao/mozilla/unified/python/mach/mach/mixin/logging.py", line 53, in log
    self._logger.log(level, format_str, extra={"action": action, "params": params})
  File "/usr/lib/python3.9/logging/__init__.py", line 1512, in log
    self._log(level, msg, args, **kwargs)
  File "/usr/lib/python3.9/logging/__init__.py", line 1589, in _log
    self.handle(record)
  File "/usr/lib/python3.9/logging/__init__.py", line 1599, in handle
    self.callHandlers(record)
  File "/home/dao/mozilla/unified/third_party/python/sentry_sdk/sentry_sdk/integrations/logging.py", line 77, in sentry_patched_callhandlers
    return old_callhandlers(self, record)
  File "/usr/lib/python3.9/logging/__init__.py", line 1661, in callHandlers
    hdlr.handle(record)
  File "/usr/lib/python3.9/logging/__init__.py", line 952, in handle
    self.emit(record)
  File "/home/dao/mozilla/unified/python/mozbuild/mozbuild/controller/building.py", line 623, in emit
    msg = self.format(record)
  File "/usr/lib/python3.9/logging/__init__.py", line 927, in format
    return fmt.format(record)
  File "/home/dao/mozilla/unified/python/mach/mach/logging.py", line 143, in format
    return rv + self.sgr0

Comment 1

[Jens Stutte [:jstutte]]

Same here on Arch. I did a recent upgrade of python:

[2021-12-04T16:48:35+0100] [ALPM] upgraded python (3.9.7-2 -> 3.9.9-1)

and I think since then I did not launch mach until today.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1744665 - un-bust local builds failing with rv being undefined in mach logging code, r?glandium

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26c3e7e5467c
un-bust local builds failing with rv being undefined in mach logging code, r=glandium

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/cd2d02b3fc82
un-bust local builds failing with rv being undefined in mach logging code, r=glandium a=Aryx

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/26c3e7e5467c

Comment 6

[Alex Hochheiden [:ahochheiden]]

Thanks for fixing this. I should have caught it during review.

Apologies for the inconvenience.