Closed Bug 1744706 Opened 2 years ago Closed 2 years ago

Always show the git commit in fetch task logs

Categories

(Firefox Build System :: Task Configuration, task)

task

Tracking

(firefox97 fixed)

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

99% of the fetch tasks that pull from a git repo pull from a specific revision, as specifically intended. There is however one exception, which is the clang-trunk fetch, which is intended to always pull the last revision on clang trunk. Unfortunately, the log also doesn't say what specific commit it checked out.

99% of the fetch tasks that pull from a git repo pull from a specific
revision, as specifically intended. There is however one exception,
which is the clang-trunk fetch, which is intended to always pull the
last revision on clang trunk. Unfortunately, the log also doesn't say
what specific commit it checked out.

Ironically, the log for all the other tasks does say which commit is
checked out, because git prints it out when it goes in detached head
state, which it does when checking out a specific sha1 (so in that
case, it's printing something we already know).

In the one instance where we checkout a branch, we don't rely on the
branch being checked out, so we just forcibly go in the same state of
detached head in that case too.

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/9d5b5b1e9944
Always show the git commit in fetch task logs. r=taskgraph-reviewers,aki
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: