Open Bug 1744709 Opened 8 months ago Updated 2 months ago

File saved via double-click in the attachment area doesn't show in the list of saved files (Ctrl+J)

Categories

(Thunderbird :: Mail Window Front End, defect)

Thunderbird 96
defect

Tracking

(thunderbird_esr102 affected)

ASSIGNED
Tracking Status
thunderbird_esr102 --- affected

People

(Reporter: rachel, Assigned: thomas8)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

When saving a file via double-click from the attachment area, the file doesn't appear in the list of saved files any more. Visible in TB 95 beta.

Likely a regression of bug 1737711.

Keywords: regression
Regressed by: 1737711

Maybe something like this or this is missing here? Looks like the transfer stuff creates the download (entry) here (line 413).

Status: UNCONFIRMED → NEW
Ever confirmed: true

TB 91 is affected.

Geoff, maybe TB should eventually take this patch before 102 since it's a regression from the "open attachment reshuffle". Likely needs rebasing to trunk. (Strange that no user complained since we got a complaint very early on.)

We want to create an item in the downloads history aka "Saved Files" every time
when an attachment get saved, so that users won't have to dig for that file
again.

https://github.com/Betterbird/thunderbird-patches/blob/main/102/bugs/1744709-save-double-click-download.patch

Assignee: nobody → bugzilla2007
Status: NEW → ASSIGNED

(In reply to Rachel Martin from comment #5)

Geoff, maybe TB should eventually take this patch before 102 since it's a regression from the "open attachment reshuffle". Likely needs rebasing to trunk. (Strange that no user complained since we got a complaint very early on.)

Thanks Rachel for following up on this and offering your patch! This is a useful fix for an everyday basic workflow.
Geoff is on holiday for the next two weeks. I've applied this in my new (Artifact) Build Environment, and it does fix the problem without any side effects afasics. Patch uploaded for review. Awesome!

It would be preferable to keep passing in the path, instead of adding more reliance on nsIFile

nsITransfer,init() requires a nsIURI parameter, so it doesn't make sense to pass the nsIFile.path instead of nsIFile just to create another nsIFile inside the function to create the URI.

You need to log in before you can comment on or make changes to this bug.