Closed Bug 1744797 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 31934 - [FlexNG] Simple multi-line row flex fragmentation

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31934 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31934
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] Simple multi-line row flex fragmentation

Add support for simple multi-line row flex fragmentation. In order to
get this case working, we needed to update when we consider an item
to have container separation in the case of rows (i.e. when the item's
row is not the first in a given fragmentainer).

There was also an issue in the NGFlexItemIterator when handling
break tokens in the multi-line case. More specifically, we won't know
the current item's index or line index ahead of time if we're
processing a break token. Move the calculation of |current_item_idx| and
|current_line_idx| to accommodate this case.

Bug: 660611
Change-Id: I67d5c59bd541cc42b22bb462ef840d55ce5ad67e
Reviewed-on: https://chromium-review.googlesource.com/3319284
WPT-Export-Revision: 6ab64296c216832e9e8e48ed047bb669ef5b3fb2

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests

Status Summary

Firefox

PASS: 5
FAIL: 1

Chrome

PASS: 6

Safari

PASS: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/flexbox/multi-line-row-flex-fragmentation-005.html: FAIL

New Tests That Don't Pass

/css/css-break/flexbox/multi-line-row-flex-fragmentation-005.html: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/93e26dc73e52
[wpt PR 31934] - [FlexNG] Simple multi-line row flex fragmentation, a=testonly
https://hg.mozilla.org/integration/autoland/rev/5a052ecafa8f
[wpt PR 31934] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/93e26dc73e52
https://hg.mozilla.org/mozilla-central/rev/5a052ecafa8f

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.