1744888 - mostly empty page and have telemetry issues for invalid or missing values of MfM template pref

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Mark found some problems if browser.preferences.moreFromMozilla.template is either unset, or set to an invalid value:

   Setting browser.preferences.moreFromMozilla.template to badstring yields a mostly empty page. Seems unlikely to happen 🤷‍♂️

   Enabling the feature but not setting the template pref has the same result.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

[Tracking Requested - why for this release]:

If not uplifted, this would cause problems for (at least) the experiment we're planning to do in 96 release.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

The fix for this test error: https://treeherder.mozilla.org/logviewer?job_id=360150226&repo=autoland&lineNumber=2807 is what caused this regression. One possibility is that backing out that fix and changing the test instead would be a good solution. It depends in part on how we decide to solve bug 1744951.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1744888 - Telemetry and display issues in More from Mozilla experiment code, r?mstriemer

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0ac43181119
More from Mozilla not displaying sometimes, r=mstriemer,preferences-reviewers

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e0ac43181119

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dmosedale, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 9255530 [details]
Bug 1744888 - Telemetry and display issues in More from Mozilla experiment code, r?mstriemer

Beta/Release Uplift Approval Request

• User impact if declined: Prevents correct functioning of More from Mozilla 96 experiment.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Will get manual QE testing as part of the holisitic "More from Mozilla 96 experiment" QE testing in https://mozilla-hub.atlassian.net/browse/QA-1328
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only effects More from Mozilla 96 experiment.
• String changes made/needed: None

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9255530 [details]
Bug 1744888 - Telemetry and display issues in More from Mozilla experiment code, r?mstriemer

Approved for 96.0b8

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9d684254288e

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Thank you, :diannaS!

Comment 12

[Robert Martin [:romartin], Ecosystem QA]

For Firefox 96, this issue was verified as part of the testing done for [QA-1328] which concluded with a favorable for partial Testing Report.

For Firefox 97, I have verified that this issue is no longer reproducible by setting the "browser.preferences.moreFromMozilla" pref value to "true" and observing the "about:preferences#moreFromMozilla" using Firefox Nightly 97.0a1 (Build ID: 20211229214859) on Windows 10 x64, macOS 11.6, and Ubuntu Linux 20.04 x64.