1744890 - Misc cleanups in clang toolchain configs

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1744890 - Remove build_libcxx from individual configs.

And make build-clang use a sensible default corresponding to what
the configs were doing.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1744890 - Remove assertions field from clang configs.

false is the default already.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1744890 - Remove build_type field from clang configs.

Release is the default already.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1744890 - Remove compiler-rt-cross-compile.patch.

It's not needed anymore now that we cross-build the mac compiler-rt
separately.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1744890 - Use clang 13 for mar-tools toolchain builds.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1744890 - Remove unused clang toolchains.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47fc5d586ce5
Remove build_libcxx from individual configs. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/32f70d5059d5
Remove assertions field from clang configs. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/29b1008ed321
Remove build_type field from clang configs. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/984c21a8cf6a
Remove compiler-rt-cross-compile.patch. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/d335914aa101
Use clang 13 for mar-tools toolchain builds. r=firefox-build-system-reviewers,andi
https://hg.mozilla.org/integration/autoland/rev/2a8f50dbf55f
Remove unused clang toolchains. r=firefox-build-system-reviewers,andi

Comment 8

[Marian-Vasile Laza]

Backed out changeset 984c21a8cf6a (Bug 1744890) for causing build bustages.
Backout link
Push with failures
Failure Log

Comment 9

[Mike Hommey [:glandium]]

Turns out compiler-rt-cross-compile.patch is still necessary for the native mac clang builds (which we do cross-compile, but which don't get their compiler-rt from the separate compiler-rt builds)

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/47fc5d586ce5
https://hg.mozilla.org/mozilla-central/rev/32f70d5059d5
https://hg.mozilla.org/mozilla-central/rev/29b1008ed321
https://hg.mozilla.org/mozilla-central/rev/d335914aa101
https://hg.mozilla.org/mozilla-central/rev/2a8f50dbf55f