Closed Bug 1744907 Opened 2 years ago Closed 2 years ago

Let's name same log name to IME handlers and keyboard handlers across platforms

Categories

(Core :: DOM: UI Events & Focus Handling, enhancement, P3)

Desktop
All
enhancement

Tracking

()

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

Details

(Keywords: inputmethod)

Attachments

(1 file)

Currently, we use different name for IME handlers and native keyboard event handlers per platform. However, it's hard to remember. I think that all of them should have same name across platforms. Then, we can tell bug reporters that how to log the behavior in their environments easier.

Currently, log names of IME handlers and keyboard event handlers are considered
from the class names. However, some of them are older name, and some of them
are for multiple classes. This is hard to remember when I tell bug reporters
to log the behavior in their environment. Therefore, I'd like to name all
IME handlers' log module name is IMEHandler, and all keyboard handlers'
log module name is KeyboardHandler.

Without dumping each key mapping on Windows, the log level 4 (LogLevel::Debug)
is enough. KeyboardHandler:5 is really noisy on Windows. So, new logging
preparation becomes:

MOZ_LOG=IMEHandler:4,sync
MOZ_LOG=KeyboardHandler:4,sync
or
MOZ_LOG=IMEHandler:4,KeyboardHandler:4,sync

Attachment #9254271 - Attachment description: WIP: Bug 1744907 - Rename all IME log module name to `IMEHandler` and all keyboard log module name to `KeyboardHandler` on desktop environment r=m_kato! → Bug 1744907 - Rename all IME log module name to `IMEHandler` and all keyboard log module name to `KeyboardHandler` on desktop environment r=m_kato!
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/f8910918e87c
Rename all IME log module name to `IMEHandler` and all keyboard log module name to `KeyboardHandler` on desktop environment r=m_kato
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: