1744983 - [wpt-sync] Sync PR 31957 - [@container] Do not re-attach container inclusive ancestors

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 31957 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31957
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

[@container] Do not re-attach container inclusive ancestors

Avoid reattaching inclusive ancestors for size containers due to legacy
layout fallback during layout. Only allow marking for re-attachment up
to, but not including, a size container.

This means we will still have DCHECK failures and broken layout for
legacy fallback when container queries are enabled, but avoids
use-after-free for layout objects.

Bug: 1276962
Change-Id: If6ff862b6269fb41cceb18cc393f24667b31b827
Reviewed-on: https://chromium-review.googlesource.com/3323072
WPT-Export-Revision: 0bca354fa8e59eb1485fdb0fefc3bbceafc5438c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=40b74cba161759204cc313633ff7d61d44bfd722

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

PASS: 1
FAIL: 1

Safari

PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-contain/container-queries/multicol-inside-container.html: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de897daafce7
[wpt PR 31957] - [@container] Do not re-attach container inclusive ancestors, a=testonly
https://hg.mozilla.org/integration/autoland/rev/88ca08129bf4
[wpt PR 31957] - Update wpt metadata, a=testonly

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/de897daafce7
https://hg.mozilla.org/mozilla-central/rev/88ca08129bf4