Open Bug 1745003 Opened 2 years ago

Document the implications of overriding DOMTargetEventHelper::EventListenerAdded()/EventListenerRemoved

Categories

(Core :: DOM: Events, task)

Product:
Core
Component:
DOM: Events
Type:
task

Tracking

()

People

(Reporter: gsvelto, Unassigned)

Details

When a class inheriting from DOMTargetEventListener overrides EventListenerAdded()/EventListenerRemoved() it will effectively disable the functionality of KeepAliveIfHasListenersFor()/IgnoreKeepAliveIfHasListenersFor() as the keep-alive checks are implemented in DOMTargetEventListener::EventListenerAdded() and DOMTargetEventListener::EventListenerRemoved(). We should add a comment to the header to document this, letting the inheritor know that if it overrides those methods then event-listener keep-alives are up to the child class and won't be handled automatically.

You need to log in before you can comment on or make changes to this bug.