Closed Bug 1745059 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 31965 - URLPattern: Escape some suffixes trailing `:foo` groups.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox97 fixed)

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31965 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31965
Details from upstream follow.

Ben Kelly <wanderview@chromium.org> wrote:

URLPattern: Escape some suffixes trailing :foo groups.

This CL fixes another problem case from:

https://github.com/WICG/urlpattern/issues/145

In this case we need to detect when a group suffix could be mistaken
for trailing custom name characters. When this happens we should escape
the first character of the suffix. For example: {:foo\\bar} instead
of {:foobar}.

Bug: 1263673
Change-Id: I2aa2d043ef4c71433fdc0be113fcafddf5ad3532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318605
Reviewed-by: Jeremy Roman \<jbroman@chromium.org>
Commit-Queue: Ben Kelly \<wanderview@chromium.org>
Cr-Commit-Position: refs/heads/main@{#949707}

PR 31965 applied with additional changes from upstream: ba47328a5138c4fbbc0841dc2f5bf31ab4da0b33, 938a88f9b3121e0f88bfce4baead83af93111cad
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26538b8c8daf
[wpt PR 31965] - URLPattern: Escape some suffixes trailing `:foo` groups., a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.