1745184 - browser_asrouter_toolbarbadge.js keeps a loading animation in the first tab at the end of the test

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Florian Quèze [:florian]]

Here is a profile of the test with the patches from bug 1742842 applied: https://share.firefox.dev/3GoujZG

Captured using ./mach test browser/components/newtab/test/browser/browser_asrouter_toolbarbadge.js --profiler on my local build.

In the profile, I see that there's a "CSS animation - tab-throbber-animation" animation that keeps on running after the test is supposed to have ended. Further down in the marker chart, I see that there's a network load on https://127.0.0.1:8888/?context=fx_desktop_v3&entrypoint=fxa_app_menu&action=email&service=sync that doesn't finish.

Adding a gBrowser.stop() call at the end of the test doesn't stop the loading animation.

By commenting out many things in the test until I no longer reproduced, I noticed that it's the fxaButton.click(); line at https://searchfox.org/mozilla-central/rev/eea0fac2cb8cae1e5a2e38959eeaa0b7f6d23456/browser/components/newtab/test/browser/browser_asrouter_toolbarbadge.js#34 that triggers the behavior (both the network request, and the never ending load animation).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:daleharvey, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Florian Quèze [:florian]]

(In reply to Florian Quèze [:florian] from comment #0)

Adding a gBrowser.stop() call at the end of the test doesn't stop the loading animation.

Adding it at the end of the test doesn't work (likely because the selected tab at the end of the test wasn't the one that had the loading animation), but adding it in the clean up function registered at the beginning works!

Comment 3

[Florian Quèze [:florian]]

Attachment: Bug 1745184 - avoid keeping a tab loading animation running at the end of the browser_asrouter_toolbarbadge.js test, r=daleharvey.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c935edad84e7
avoid keeping a tab loading animation running at the end of the browser_asrouter_toolbarbadge.js test, r=daleharvey.

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/c935edad84e7