1745235 - Incorrectly styled menupopup in compose attachment reminder

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: attachment-reminder-popup.png

Another place where the m-c styling is colliding with ours.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1745235-reminderBarPopup.patch

Remove the margin.

This is Linux only.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9254599 [details] [diff] [review]
1745235-reminderBarPopup.patch

Review of attachment 9254599 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/themes/linux/mail/message-bar.css
@@ +9,5 @@
>  }
>  
>  #reminderBarPopup {
>    background-color: Menu;
> +  border-radius: var(--panel-border-radius);

The --panel-border-radius variable is not set on Linux, but I'm not sure this is correct or enough as I tried to manually add 3px radius to this element and sharp borders were visible on rollover.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1745235-reminderBarPopup.patch

Needs bug 1745244 applied first.

I overlooked that the --panel-border-radius from common.css isn't applied here. Added it to message-bar.css. On hover a little edge is visible but because of the shadow-DOM I can't add a rule for it to .menupopup-arrowscrollbox::part(scrollbox-clip).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d84085e462ec
[Linux] Remove the margin of #reminderBarPopup. r=aleca