1745246 - With Java 11 @interface IntDef, LongDef etc need to be public

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

Due to a change in the Java 11 bytecode, all the enum def @interface need to be public, otherwise downstream builds will fail with something like:

[task 2021-12-09T15:30:12.030Z] ERROR:/builds/worker/.gradle/caches/transforms-3/48cc8c0d0946de8e4fe0bd5e927fac1a/transformed/geckoview-nightly-omni-97.0.20211209093228-runtime.jar: D8: Compilation of classes org.mozilla.geckoview.Autofill, org.mozilla.geckoview.Autofill$Support, org.mozilla.geckoview.Autofill$Delegate, org.mozilla.geckoview.Autofill$Node, org.mozilla.geckoview.Autofill$Node$Builder, org.mozilla.geckoview.Autofill$Session, org.mozilla.geckoview.Autofill$InputType, org.mozilla.geckoview.Autofill$Hint, org.mozilla.geckoview.Autofill$Notify requires its nest mates org.mozilla.geckoview.Autofill$AutofillInputType, org.mozilla.geckoview.Autofill$AutofillHint, org.mozilla.geckoview.Autofill$AutofillNotify (unavailable) to be on program or class path.

see also https://openjdk.java.net/jeps/181

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1745246 - Allow specifying multiple maven artifacts from build.

This patch introduces a new field maven-artifacts which allows specifying a
list of maven artifacts that will be generated by a build and published to our
maven repository.

This allows us to split up GeckoView into separate maven packages.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1745246 - Move org/mozilla/thirdparty to mobile/android/exoplayer2.

Temporary commit to help code review.

This patch just moves the files without any further change. Actual build
changes will happen in a later patch.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1745246 - Move org/mozilla/thirdparty to it's own module.

This allows us to decouple GeckoView from exoplayer2, have it's own Java
settings and not pollute GeckoView's dependencies.

Comment 4

[Andrew Halberstadt [:ahal]]

I think this was supposed to be for unlanded patch with r+? Fine to land by me, will leave up to :agi.

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1745246 - Make @interface classes public.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/789ee91f1dfe
Allow specifying multiple maven artifacts from build. r=calu,ahal
https://hg.mozilla.org/integration/autoland/rev/e470f0d75f45
Move org/mozilla/thirdparty to mobile/android/exoplayer2. r=calu
https://hg.mozilla.org/integration/autoland/rev/604947f6662b
Move org/mozilla/thirdparty to it's own module. r=calu
https://hg.mozilla.org/integration/autoland/rev/8f0bb6fd1f53
Make @interface classes public. r=jonalmeida

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/789ee91f1dfe
https://hg.mozilla.org/mozilla-central/rev/e470f0d75f45
https://hg.mozilla.org/mozilla-central/rev/604947f6662b
https://hg.mozilla.org/mozilla-central/rev/8f0bb6fd1f53