1745281 - Investigate ways to redirect BASE_PROFILER_MARKER_* markers to Gecko Profiler buffer after it starts

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

If someone uses a BASE_PROFILER_MARKER_* function, the marker is just lost when only the Gecko Profiler is running.
It would be good to use the Gecko Profiler buffer in that case.

I'm thinking that base_profiler_marker_detail::CachedBaseCoreBuffer() could provide the Gecko Profiler buffer once it's alive.

Comment 1

[Florian Quèze [:florian]]

This would be very nice for the markers I added in bug 1524625!

Comment 2

[Florian Quèze [:florian]]

This would have been very helpful in figuring out faster what was happening in the profile of bug 1747980. I could see quickly that DLLs were being injected, but I could only find the name of the DLL in label frames that weren't as easy to find.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I've managed to get going on bug 1753192, which makes this bug here fairly simple to achieve.

Here's an example from an early prototype, showing "DllLoad" base markers during the whole profiling session: https://share.firefox.dev/34fDi1U

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1745281 - Test base/gecko markers before/during/after base/gecko profiler - r?canaltinova

This adds tests about what's already happening with current Base and Gecko Profiler markers.

Depends on D137805

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1745281 - Record base markers whenever the core buffer is in session - r?canaltinova

Depends on D137808

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a041d78df6f
Test base/gecko markers before/during/after base/gecko profiler - r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/d3ade0cdc753
Record base markers whenever the core buffer is in session - r=canaltinova

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/7a041d78df6f
https://hg.mozilla.org/mozilla-central/rev/d3ade0cdc753