1745314 - [wpt-sync] Sync PR 31984 - Fix crash when an appHistory currentchange event handler starts a reentrant navigation

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 31984 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31984
Details from upstream follow.

Nate Chapin <[e-mail]> wrote:

Fix crash when an appHistory currentchange event handler starts a reentrant navigation

AppHistory::UpdateForNavigation() (which fires currentchange) is called
just before sending IPCs to the browser process for the conclusion of a
same document navigation. It should be called after, so that we do not
interleave IPCs from different same document navigations.

Bug: 1278519
Test: external/wpt/app-history/navigate-event/transitionWhile-and-navigate.html
Change-Id: I462fc206fadd9342193cad59b8747cf8879a6eae

Reviewed-on: https://chromium-review.googlesource.com/3327957
WPT-Export-Revision: 290c90ebd929203fade280796769feaba78c67b2

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=032e176ef7fb7e252b4ae3363f3a8530b2bac6c9

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1

Chrome

FAIL : 1
ERROR: 1

Safari

OK : 1
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/app-history/navigate-event/transitionWhile-and-navigate.html
Using transitionWhile then navigate() in the ensuing currentchange should abort the transitionWhile: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c44a75beae0
[wpt PR 31984] - Fix crash when an appHistory currentchange event handler starts a reentrant navigation, a=testonly
https://hg.mozilla.org/integration/autoland/rev/bd938dbf3bb3
[wpt PR 31984] - Update wpt metadata, a=testonly

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2c44a75beae0
https://hg.mozilla.org/mozilla-central/rev/bd938dbf3bb3