Closed Bug 1745325 Opened 2 years ago Closed 2 years ago

Remove unnecessary setting of print.tab_modal.enabled=true in tests

Categories

(Toolkit :: Printing, task)

Product:
Toolkit
Component:
Printing
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

Bug 1745325 - Remove unnecessary setting of `print.tab_modal.enabled=true` in tests. r=hiro
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Attachment #9254688 - Attachment description: WIP: Bug 1745325 - Remove unnecessary setting of `print.tab_modal.enabled=true` in tests → Bug 1745325 - Remove unnecessary setting of `print.tab_modal.enabled=true` in tests
Attachment #9254688 - Attachment description: Bug 1745325 - Remove unnecessary setting of `print.tab_modal.enabled=true` in tests → Bug 1745325 - Remove unnecessary setting of `print.tab_modal.enabled=true` in tests. r=hiro
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/01eb21de6aef
Remove unnecessary setting of `print.tab_modal.enabled=true` in tests. r=hiro
Blocks: 1657733

Backed out for causing mochitest failures on browser_preview_print_coop.js.

Range with backfills

Failure log

Backout link

[task 2021-12-10T05:06:24.490Z] 05:06:24     INFO - TEST-START | toolkit/components/printing/tests/browser_preview_print_coop.js
[task 2021-12-10T05:06:25.615Z] 05:06:25     INFO - GECKO(16723) | [Parent 16723, Main Thread] WARNING: GDBus.Error:org.freedesktop.DBus.Error.Spawn.FileInvalid: Cannot do system-bus activation with no user
[task 2021-12-10T05:06:25.616Z] 05:06:25     INFO - GECKO(16723) | : 'glib warning', file /builds/worker/checkouts/gecko/toolkit/xre/nsSigHandlers.cpp:139
[task 2021-12-10T05:06:25.617Z] 05:06:25     INFO - GECKO(16723) | ** (firefox:16723): WARNING **: 05:06:25.613: GDBus.Error:org.freedesktop.DBus.Error.Spawn.FileInvalid: Cannot do system-bus activation with no user
[task 2021-12-10T05:06:25.619Z] 05:06:25     INFO - GECKO(16723) | [Parent 16723, Main Thread] WARNING: GDBus.Error:org.freedesktop.DBus.Error.Spawn.FileInvalid: Cannot do system-bus activation with no user
[task 2021-12-10T05:06:25.620Z] 05:06:25     INFO - GECKO(16723) | : 'glib warning', file /builds/worker/checkouts/gecko/toolkit/xre/nsSigHandlers.cpp:139
[task 2021-12-10T05:06:25.621Z] 05:06:25     INFO - GECKO(16723) | ** (firefox:16723): WARNING **: 05:06:25.614: GDBus.Error:org.freedesktop.DBus.Error.Spawn.FileInvalid: Cannot do system-bus activation with no user
[task 2021-12-10T05:06:30.574Z] 05:06:30     INFO - TEST-INFO | started process screentopng
[task 2021-12-10T05:06:30.904Z] 05:06:30     INFO - TEST-INFO | screentopng: exit 0
[task 2021-12-10T05:06:30.905Z] 05:06:30     INFO - Buffered messages logged at 05:06:24
[task 2021-12-10T05:06:30.906Z] 05:06:30     INFO - Entering test bound test
[task 2021-12-10T05:06:30.907Z] 05:06:30     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "about:printpreview" line: 0}]
[task 2021-12-10T05:06:30.908Z] 05:06:30     INFO - Buffered messages logged at 05:06:25
[task 2021-12-10T05:06:30.909Z] 05:06:30     INFO - TEST-PASS | toolkit/components/printing/tests/browser_preview_print_coop.js | We did not crash. - 
[task 2021-12-10T05:06:30.910Z] 05:06:30     INFO - Leaving test bound test
[task 2021-12-10T05:06:30.911Z] 05:06:30     INFO - Entering test bound testTabModal
[task 2021-12-10T05:06:30.913Z] 05:06:30     INFO - withTestPage: http://example.com/browser/toolkit/components/printing/tests/file_coop_header.html
[task 2021-12-10T05:06:30.914Z] 05:06:30     INFO - Buffered messages finished
[task 2021-12-10T05:06:30.915Z] 05:06:30     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/printing/tests/browser_preview_print_coop.js | Uncaught exception - Wait for dialog - timed out after 50 tries.
[task 2021-12-10T05:06:30.917Z] 05:06:30     INFO - Leaving test bound testTabModal
[task 2021-12-10T05:06:30.917Z] 05:06:30     INFO - GECKO(16723) | MEMORY STAT | vsize 11478MB | residentFast 461MB | heapAllocated 230MB
[task 2021-12-10T05:06:30.917Z] 05:06:30     INFO - TEST-OK | toolkit/components/printing/tests/browser_preview_print_coop.js | took 6096ms
[task 2021-12-10T05:06:30.917Z] 05:06:30     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-12-10T05:06:30.919Z] 05:06:30     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/printing/tests/browser_preview_print_coop.js | Found an unexpected tab at the end of test run: http://example.com/browser/toolkit/components/printing/tests/file_coop_header.html - 
[task 2021-12-10T05:06:30.919Z] 05:06:30     INFO - checking window state
[task 2021-12-10T05:06:30.919Z] 05:06:30     INFO - GECKO(16723) | must wait for focus
[task 2021-12-10T05:12:21.921Z] 05:12:21     INFO - Console message: [JavaScript Warning: "telemetry.state_file_read_errors - Unknown scalar."]
[task 2021-12-10T05:12:21.922Z] 05:12:21     INFO - Console message: [JavaScript Warning: "telemetry.generated_new_client_id - Unknown scalar."]
[task 2021-12-10T05:14:21.920Z] 05:14:21     INFO - GECKO(16723) | 1639113261918	addons.xpi	ERROR	System addon update list error Error: got node name: html, expected: updates
[task 2021-12-10T05:14:21.923Z] 05:14:21     INFO - Console message: [JavaScript Error: "1639113261918	addons.xpi	ERROR	System addon update list error Error: got node name: html, expected: updates" {file: "resource://gre/modules/Log.jsm" line: 723}]
[task 2021-12-10T05:14:21.923Z] 05:14:21     INFO - append@resource://gre/modules/Log.jsm:723:12
[task 2021-12-10T05:14:21.923Z] 05:14:21     INFO - log@resource://gre/modules/Log.jsm:379:16
[task 2021-12-10T05:14:21.924Z] 05:14:21     INFO - error@resource://gre/modules/Log.jsm:387:10
[task 2021-12-10T05:14:21.924Z] 05:14:21     INFO - updateSystemAddons/res<@resource://gre/modules/addons/XPIInstall.jsm:4055:25
[task 2021-12-10T05:14:21.924Z] 05:14:21     INFO - 
[task 2021-12-10T05:20:31.943Z] 05:20:31     INFO - Buffered messages finished
[task 2021-12-10T05:20:31.943Z] 05:20:31    ERROR - TEST-UNEXPECTED-TIMEOUT | toolkit/components/printing/tests/browser_preview_print_coop.js (finished) | application timed out after 370 seconds with no output
[task 2021-12-10T05:20:31.943Z] 05:20:31    ERROR - Force-terminating active process(es).
Flags: needinfo?(jwatt)

I've fixed up that test in bug 1745301. it seems a bit weird that one of the tests modified in this bug was masking that issue though...

Flags: needinfo?(jwatt)
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/d508a381826a
Remove unnecessary setting of `print.tab_modal.enabled=true` in tests. r=hiro

https://hg.mozilla.org/mozilla-central/rev/d508a381826a

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: