1745348 - "Manage bookmarks" button in hotdog menu is broken

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Winson Wen]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:97.0) Gecko/20100101 Firefox/97.0

Steps to reproduce:

Open the hotdog menu
Open the "Bookmarks" sub-menu
Click on "Manage bookmarks"

Actual results:

Nothing

Expected results:

Library window is opened

The Ctrl+Shift+O keyboard shortcut still opens the Library window successfully, as well as the "Manage bookmarks" option in the Bookmarks menu. Only through the hotdog menu does it appear broken

Mozregression is pointing to:
Bug 1714846 - Really hide panels on hide, r=robwu,emilio

Differential Revision: https://phabricator.services.mozilla.com/D132574

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Mark Banner (:standard8)]

Gijs, can you take a look please?

Comment 3

[:Gijs (he/him)]

(In reply to Mark Banner (:standard8) from comment #2)

Gijs, can you take a look please?

Yeah, thanks for the ping.

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1745348 - bookmark subview items shouldn't try to hide the panel themselves, breaking the command/oncommand handling, r?Standard8

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1714846

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/043f886c0e72
bookmark subview items shouldn't try to hide the panel themselves, breaking the command/oncommand handling, r=Standard8

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/043f886c0e72

Comment 9

[Giorgia Nichita, Release Desktop QA]

I was able to reproduce this issue on Windows 10 x64, using an affected build 97.0a1 (20211209155024).
Verified fixed on 97.0b5 (20220118185733) across the following platforms: Windows 10 x64, Ubuntu 20.04, macOS 10.14.