Closed Bug 1745422 Opened 2 years ago Closed 2 years ago

No box appears in the all tags area of the Edit bookmark panel in light theme

Categories

(Toolkit :: Themes, defect, P2)

Firefox 95
Desktop
Windows 10
defect

Tracking

()

VERIFIED FIXED
97 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox95 --- wontfix
firefox96 --- wontfix
firefox97 --- verified
firefox98 --- verified

People

(Reporter: alice0775, Assigned: emilio)

References

(Regression)

Details

(Keywords: nightly-community, papercut, regression)

Attachments

(2 files)

Steps to reproduce:

  1. Light theme(System default on OS light color)
  2. Click Star Button in Address bar
  3. Click Show all tags button to expand tags

Actual Results:
No box.
See screenshot

Expected Results:
All tags area should have a border.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1ff04e10cd2318b494c0f05777cd80291289d127&tochange=d39b23efefe7e7d89d8dfd0ba188ad6af2b0a9ed

Severity: -- → S4
Keywords: papercut
Priority: -- → P2

NI for emilio based on regression range.

Flags: needinfo?(emilio)
Assignee: nobody → emilio
Flags: needinfo?(emilio)

This used to be provided by the default appearance.

Note that in-content richlistboxes already have it so we only need to audit the
ones that are not in-content and set appearance: none (to remove the border).

I believe I caught all of them but ICBW.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74a8a97d2598
Add a border to richlistbox on Windows. r=dao,desktop-theme-reviewers
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
Flags: qe-verify+

I was able to reproduce the issue on Win10x64 using build 97.0a1 (20211210215852).
Verified as fixed on Win10x64 using build Beta 97.0b2(20220111185943) and NB 98.0a1(20220113093336).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: