1745554 - [Windows] Wrong folder pane icons and message thread colors in High Contrast Mode

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: hg-new-email.png

STR

• On Window 11 set High Contrast Theme to "Dusk"
• Receive a new message

The message text is dark and not properly readable.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1745554-HCT-unread.patch

This happens too on the other Windows since the Highlight to SelectedItem change which also changed the -moz-cellhighlighttext colour. But honestly, I don't know why I've chosen this colour then when implementing it.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9254914 [details] [diff] [review]
1745554-HCT-unread.patch

Review of attachment 9254914 [details] [diff] [review]:
-----------------------------------------------------------------

This fixes that scenario, but there are other adjacent scenarios in which the HGC don't work well.
Attaching screenshots here as we should tackle them all together.

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: hg-unread-msg-folder.png

When there are unread emails in a folder and the Folder Pane is not selected, the folder icon is dark.

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: hg-unselected-row.png

When a row is selected, but the focus is on another pane, the icons of that row are dark.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1745554-HCT-unread.patch

This should fix both issues. I also fixed that when a new message arrives and the folder is selected the icon has the same colour as the background. We're very limited with colours and we can only use the SelectedItemText for this.

Comment 6

[Alessandro Castellani [:aleca]]

Comment on attachment 9255201 [details] [diff] [review]
1745554-HCT-unread.patch

Review of attachment 9255201 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

::: mail/themes/windows/mail/messenger.css
@@ +90,2 @@
>      --toolbarbutton-active-background: SelectedItem;
>      --toolbarbutton-active-bordercolor: SelectedItemText;

Should we also remove this?

Comment 7

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani [:aleca] from comment #6)

::: mail/themes/windows/mail/messenger.css
@@ +90,2 @@

 --toolbarbutton-active-background: SelectedItem;
 --toolbarbutton-active-bordercolor: SelectedItemText;

Should we also remove this?

No, they are used for the buttons in the main toolbar and other places. The background variable for the header buttons too.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1cdf5f28b208
Remove special high contrast unread message rules. r=aleca