Closed Bug 1745676 Opened 2 years ago Closed 2 years ago

Save to local doesn't work if canceled during copying

Categories

(MailNews Core :: Composition, defect)

defect

Tracking

(thunderbird_esr91 fixed, thunderbird96 fixed)

RESOLVED FIXED
97 Branch
Tracking Status
thunderbird_esr91 --- fixed
thunderbird96 --- fixed

People

(Reporter: rnons, Assigned: rnons)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

A bug found when testing bug 1744946.

STR:

  1. have 2 accounts: a@local, b@local
  2. change the imap password of b@local to an invalid password
  3. config a@local to place a copy in the Sent folder of b@local
  4. send a mail from a@local, the progress dialog should hang at Sending login information.., which is trying to connect to the imap server of b@local
  5. click the Cancel button, a Save Message dialog should show up, with options to Retry or Save to local
  6. click the Save button will throw an error JavaScript error: resource:///modules/MessageSend.jsm, line 835: TypeError: can't access property "path", this._messageFile is null
Assignee: nobody → remotenonsense
Status: NEW → ASSIGNED

Do not remove messageFile when abort sending, notifyListenerOnStopCopy will take care of it

Target Milestone: --- → 97 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/ff6e535d0d41
Fix saving message to local when sending canceled during copying. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Comment on attachment 9254965 [details]
Bug 1745676 - Fix saving message to local when sending canceled during copying. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1211292
User impact if declined: In some cases, tmp msg file is removed too early, can't save a Sent copy to the local folders.
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9254965 - Flags: approval-comm-esr91?
Attachment #9254965 - Flags: approval-comm-beta?

Comment on attachment 9254965 [details]
Bug 1745676 - Fix saving message to local when sending canceled during copying. r=mkmelin

[Triage Comment]
Approved for beta

Attachment #9254965 - Flags: approval-comm-beta? → approval-comm-beta+
Whiteboard: [TM:91.5.1]

Comment on attachment 9254965 [details]
Bug 1745676 - Fix saving message to local when sending canceled during copying. r=mkmelin

[Triage Comment]
Approved for esr91

Attachment #9254965 - Flags: approval-comm-esr91? → approval-comm-esr91+
Whiteboard: [TM:91.5.1]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: