174576 - imported bookmark tab-group doesn't work like new phoenix bookmarks folder

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Azrael AOD]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021014 Phoenix/0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021014 Phoenix/0.3

I like the way in which phoenix now allows any folder of bookmarks to be opened
as a group of tabs. I have imported my Mozilla bookmarks.html file into Phoenix
bookmarks. All of the folders of bookmarks (from mozilla) display an 'Open in
tabs' option at the bottom. However, all of the new folders of bookmarks that
used to be a group of tabs in mozilla do not work the same way. They exist as a
discrete folder, but that folder does NOT have an 'Open in tabs' option at the
bottom.

Reproducible: Always

Steps to Reproduce:
1. Create a bookmarks folder in Mozilla
2. Create a bookmarked group of tabs in Mozilla
3. Import the mozilla bookmarks into Phoenix

Actual Results:  
Both the folders operate differently. One has an 'Open in tabs' option (former),
one does not (latter).

Expected Results:  
Phoenix should treat a bookmarked group of tabs like a normal bookmarks folder.

The source of the mozilla bookmarks.html file showing a different between the
normal folder, and the tab-group:

    <DT><H3 ADD_DATE="1029543020" LAST_MODIFIED="1029543032"
ID="NC:BookmarksRoot#$da35b75b">normal folder</H3>
    <DL><p>
        <DT><A HREF="http://www.lmp3.net/" ADD_DATE="1029542858"
LAST_VISIT="1029542852" LAST_CHARSET="ISO-8859-1">::: Lmp3.net :::</A>
        <DT><A HREF="http://www.cygwin.com/" ADD_DATE="1026841704"
LAST_VISIT="1028465890" ICON="http://cygwin.com/cygwin-icon.gif"
LAST_CHARSET="ISO-8859-1">Cygwin</A>
    </DL>
    <p>
    
    <DT><H3 ADD_DATE="1030103426" LAST_MODIFIED="1030103426" FOLDER_GROUP="true"
ID="NC:BookmarksRoot#$68096703">tab group</H3>
    <DL><p>
        <DT><A
HREF="http://ftp.ibiblio.org/pub/Linux/distributions/contrib/texstar/screenshots/redhat01.jpg"
ADD_DATE="1030103426" LAST_CHARSET="ISO-8859-1">redhat01.jpg (JPEG Image,
800x600 pixels)</A>
        <DT><A
HREF="http://ftp.ibiblio.org/pub/Linux/distributions/contrib/texstar/screenshots/redhat20.jpg"
ADD_DATE="1030103426" LAST_CHARSET="ISO-8859-1">redhat20.jpg (JPEG Image,
1024x768 pixels)</A>
    </DL>

The source of the phoenix bookmarks.html file:

    <HR>
    <DT><H3 ADD_DATE="1029543020" LAST_MODIFIED="1029543032"
ID="NC:BookmarksRoot#$2e3a56d9">normal folder</H3>
    <DL><p>
        <DT><A HREF="http://www.lmp3.net/" ADD_DATE="1029542858"
LAST_VISIT="1029542852" LAST_CHARSET="ISO-8859-1">::: Lmp3.net :::</A>
        <DT><A HREF="http://www.cygwin.com/" ADD_DATE="1026841704"
LAST_VISIT="1028465890" ICON="http://cygwin.com/cygwin-icon.gif"
LAST_CHARSET="ISO-8859-1">Cygwin</A>
    </DL><p>
    <DT><H3 ADD_DATE="1030103426" LAST_MODIFIED="1030103426" FOLDER_GROUP="true"
ID="NC:BookmarksRoot#$2e3a56da">tab group</H3>
    <DL><p>
        <DT><A
HREF="http://ftp.ibiblio.org/pub/Linux/distributions/contrib/texstar/screenshots/redhat01.jpg"
ADD_DATE="1030103426" LAST_CHARSET="ISO-8859-1">redhat01.jpg (JPEG Image,
800x600 pixels)</A>
        <DT><A
HREF="http://ftp.ibiblio.org/pub/Linux/distributions/contrib/texstar/screenshots/redhat20.jpg"
ADD_DATE="1030103426" LAST_CHARSET="ISO-8859-1">redhat20.jpg (JPEG Image,
1024x768 pixels)</A>
    </DL><p>
    
Suggestion: When importing Mozilla bookmarks, do not copy across the 
FOLDER_GROUP="true" attribute - thus turning the folder into a normal one. I
assume that then Phoenix will treat it properly.

Comment 1

[Azrael AOD]

Attachment: example of a group of tabs not showing 'open in tabs' option after imported into phoenix

example of a group of tabs (from Mozilla) not showing 'open in tabs' option
after being imported into phoenix

Comment 2

[Pierre Chanial]

*** Bug 174586 has been marked as a duplicate of this bug. ***

Comment 3

[Pierre Chanial]

fixed

Comment 4

[Azrael AOD]

Can I add a comment here of something I think  is associated with this problem?
Ok, thanks, I will then :)

Am using a nightly build that seems to include this fix (or at least the menu
bookmarks all work ok now). However in the sidebar bookmarks, imported
tab-groups and imported folder have _different_ icons. An imported tab-group
displays as a single icon without an expander symbol ( + ). But it still has a
context menu expand/collapse option which works.

I'm not sure what the fix was exactly. If it was a change in how the import
facility wrote the new bookmarks, or if it was a change in how the display code
read and presented them.

As there is still a noticeable difference after import, I assume that the fix
was in presentation, and not the import procedure. This means that the fix needs
to also take account of the sidebar.

Personally I think (unless it is and I am mistaken) that the fix should be done
in the import code, so as not to show a difference at all between a folder, and
a tab-group.

(looking at bookmarks.html in phoenix suggests that the import procedure has not
changed .. but I'm not brave enough to re-open this bug and suggest that the fix
wasn't a good enough one.. )

Comment 5

[Azrael AOD]

using: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021020
Phoenix/0.3
I still see the eroneus behaviour in the bookmarks sidebar tab.
Should I open that as a new bug, or because the cause is the same as this one,
re-open this one?

Comment 6

[Azrael AOD]

Attachment: bookmarks sidebar showing a tab-group as a single icon, with no expander, it should behave as a folder

The icon should display as a folder icon, and it doesn't. However it does have
the context menu of one (including expand/collapse). The cause of this is still
that the bookmarks.html source uses FOLDER_GROUP="true" when importing a
mozilla tab-group. Because this is no longer needed, Phoenix should prune
FOLDER_GROUP="true" out of the source.

Comment 7

[Azrael AOD]

re-opening this bug to get my most recent comments looked at, and because as
they explain, I think the cause of this bug still exists. It is not enough to
re-write the bookmarks menu, either every instance where bookmarks are used (eg
sidebar too) needs to be fixed (ignoring FOLDER_GROUP="true" ) or as I recommend
the import facility should scan the imported bookmerks file and delete the
FOLDER_GROUP="true" attributes, as phoenix doesn't need them.
If I am wrong, then don't hesitate to jump on me, beat me up, and close the bug
again :)

Comment 8

[Pierre Chanial]

it should be fixed, now.
mozilla groupmarks should be imported as folders.

Comment 9

[Brant Gurganus]

VERIFIED Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030714
Mozilla Firebird/0.6