Closed Bug 1745804 Opened 3 years ago Closed 3 years ago

Remove unused manifests for page load tests

Categories

(Testing :: Raptor, task, P1)

Default
task

Tracking

(firefox97 fixed)

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: kimberlythegeek, Assigned: kimberlythegeek)

References

Details

Attachments

(1 file)

A few manifests did not get removed after updating tests/removing tests, though they are no longer needed

Review any remove any manifests no longer in use

One of these manifests is used in our unit tests

Depends on: 1739423
Severity: -- → S3
Priority: -- → P1
Attachment #9255092 - Attachment description: WIP: Bug 1745804: Remove unused manifests for page load tests → Bug 1745804: Remove unused manifests for page load tests
Depends on: 1747810
Pushed by ksereduck@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/649a1395ee6c Remove unused manifests for page load tests r=perftest-reviewers,AlexandruIonescu
Regressions: 1747910
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch

Backed out for causing Bug 1747910. Will be merged to central in the coming merge.

Backout link: https://hg.mozilla.org/integration/autoland/rev/7f35691449503894cad6e0513bbdfdce7f3a6b09.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&fromchange=432387e4879b8543d39a69fca5bd74d661cd9523&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Cshippable%2Copt%2Cbrowsertime%2Cperformance%2Ctests%2Con%2Cfirefox%2Ctest-linux1804-64-shippable-qr%2Fopt-browsertime-tp6-firefox-imgur-e10s%2Cimgur&tochange=649a1395ee6c9e7a26cc6f1241a7b9c0e49e7dc7&group_state=expanded&selectedTaskRun=b-t2TJltQxeViC1x5CFsDg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=362616271&repo=autoland

[task 2021-12-29T16:38:33.781Z] 16:38:33     INFO -  raptor-mitmproxy Info: mozproxy_dir used for mitmproxy downloads and exe files: /home/cltbld/tasks/task_164078054761266/testing/mozproxy
[task 2021-12-29T16:38:33.781Z] 16:38:33     INFO -  raptor-mitmproxy Info: Playback tool: mitmproxy
[task 2021-12-29T16:38:33.781Z] 16:38:33     INFO -  raptor-mitmproxy Info: Playback tool version: 5.1.1
[task 2021-12-29T16:38:33.781Z] 16:38:33     INFO -  raptor-mitmproxy Info: create mitmproxy 5.1.1 dir
[task 2021-12-29T16:38:33.781Z] 16:38:33     INFO -  raptor-mitmproxy Info: downloading mitmproxy binary
[task 2021-12-29T16:38:33.863Z] 16:38:33     INFO -  raptor-mitmproxy Info: b'INFO - File mitmproxy-5.1.1-linux.tar.gz retrieved from local cache /builds/tooltool_cache'
[task 2021-12-29T16:38:33.903Z] 16:38:33     INFO -  raptor-mitmproxy Info: b'INFO - untarring "mitmproxy-5.1.1-linux.tar.gz"'
[task 2021-12-29T16:38:34.004Z] 16:38:34    ERROR -  raptor-mitmproxy Error: Zip or manifest file path (/home/cltbld/tasks/task_164078054761266/build/tests/raptor/raptor/tooltool-manifests/playback/mitm5-linux-firefox-imgur.manifest) does not exist. Please provide a valid path!
[task 2021-12-29T16:38:34.004Z] 16:38:34     INFO -  raptor-mitmproxy Info: MitmproxyDesktop stop!!
[task 2021-12-29T16:38:34.004Z] 16:38:34     INFO -  raptor-mitmproxy Info: Mitmproxy stop!!
[task 2021-12-29T16:38:34.004Z] 16:38:34     INFO -  raptor-perftest Info: Removing temporary directory: /tmp/tmpevul8myr
[task 2021-12-29T16:38:34.010Z] 16:38:34    ERROR -  Traceback (most recent call last):
[task 2021-12-29T16:38:34.011Z] 16:38:34     INFO -    File "/home/cltbld/tasks/task_164078054761266/build/tests/raptor/raptor/raptor.py", line 213, in <module>
[task 2021-12-29T16:38:34.011Z] 16:38:34     INFO -      main()
[task 2021-12-29T16:38:34.011Z] 16:38:34     INFO -    File "/home/cltbld/tasks/task_164078054761266/build/tests/raptor/raptor/raptor.py", line 159, in main
[task 2021-12-29T16:38:34.011Z] 16:38:34     INFO -      success = raptor.run_tests(raptor_test_list, raptor_test_names)
[task 2021-12-29T16:38:34.011Z] 16:38:34     INFO -    File "/home/cltbld/tasks/task_164078054761266/build/tests/raptor/raptor/perftest.py", line 457, in run_tests
[task 2021-12-29T16:38:34.011Z] 16:38:34     INFO -      self.run_test(test, timeout=int(test.get("page_timeout")))
[task 2021-12-29T16:38:34.012Z] 16:38:34     INFO -    File "/home/cltbld/tasks/task_164078054761266/build/tests/raptor/raptor/browsertime/base.py", line 450, in run_test
[task 2021-12-29T16:38:34.012Z] 16:38:34     INFO -      self.run_test_setup(test)
[task 2021-12-29T16:38:34.012Z] 16:38:34     INFO -    File "/home/cltbld/tasks/task_164078054761266/build/tests/raptor/raptor/browsertime/base.py", line 116, in run_test_setup
[task 2021-12-29T16:38:34.012Z] 16:38:34     INFO -      super(Browsertime, self).run_test_setup(test)
[task 2021-12-29T16:38:34.013Z] 16:38:34     INFO -    File "/home/cltbld/tasks/task_164078054761266/build/tests/raptor/raptor/perftest.py", line 440, in run_test_setup
[task 2021-12-29T16:38:34.013Z] 16:38:34     INFO -      self.start_playback(test)
[task 2021-12-29T16:38:34.013Z] 16:38:34     INFO -    File "/home/cltbld/tasks/task_164078054761266/build/tests/raptor/raptor/perftest.py", line 548, in start_playback
[task 2021-12-29T16:38:34.013Z] 16:38:34     INFO -      self.playback.start()
[task 2021-12-29T16:38:34.014Z] 16:38:34     INFO -    File "/home/cltbld/tasks/task_164078054761266/build/venv/lib/python3.6/site-packages/mozproxy/backends/mitm/mitm.py", line 237, in start
[task 2021-12-29T16:38:34.014Z] 16:38:34     INFO -      self.download()
[task 2021-12-29T16:38:34.014Z] 16:38:34     INFO -    File "/home/cltbld/tasks/task_164078054761266/build/venv/lib/python3.6/site-packages/mozproxy/backends/mitm/mitm.py", line 217, in download
[task 2021-12-29T16:38:34.014Z] 16:38:34     INFO -      self.download_playback_files()
[task 2021-12-29T16:38:34.014Z] 16:38:34     INFO -    File "/home/cltbld/tasks/task_164078054761266/build/venv/lib/python3.6/site-packages/mozproxy/backends/mitm/mitm.py", line 197, in download_playback_files
[task 2021-12-29T16:38:34.014Z] 16:38:34     INFO -      raise Exception("Zip or manifest file path does not exist")
[task 2021-12-29T16:38:34.014Z] 16:38:34     INFO -  Exception: Zip or manifest file path does not exist
[task 2021-12-29T16:38:34.055Z] 16:38:34    ERROR - Return code: 1
Flags: needinfo?(ksereduck)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 97 Branch → ---
Attachment #9255092 - Attachment description: Bug 1745804: Remove unused manifests for page load tests → WIP: Bug 1745804: Remove unused manifests for page load tests
Flags: needinfo?(ksereduck)
Attachment #9255092 - Attachment description: WIP: Bug 1745804: Remove unused manifests for page load tests → Bug 1745804: Remove unused manifests for page load tests
Pushed by ksereduck@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7b3356a87e0e Remove unused manifests for page load tests r=perftest-reviewers,AlexandruIonescu
No longer depends on: 1747810
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: