1745870 - trr_connection_cycle_count scalar is defined as keyed, but we increment it as if it isn't

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

We're calling ScalarAdd here: https://searchfox.org/mozilla-central/rev/21a9b72545da06681db97c4b3a2a6be761f4aae5/netwerk/protocol/http/TRRServiceChannel.cpp#500-501

But it's a keyed scalar: https://searchfox.org/mozilla-central/rev/21a9b72545da06681db97c4b3a2a6be761f4aae5/toolkit/components/telemetry/Scalars.yaml#6212

So we should be calling KeyedScalarAdd. I'm kinda disappointed that this isn't prevented statically...

FWIW this is my theory for why the probe shows up as "Inactive" in Glam. It's possible there's more that's wrong here, but hopefully not.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1745870 - Increment networking_trr_connection_cycle_count as a keyed scalar. r=#necko

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Quick correction to comment 0: it's not KeyedScalarAdd, there's an overload of ScalarAdd that accepts a key.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d5dd0d2ecaa
Increment networking_trr_connection_cycle_count as a keyed scalar. r=necko-reviewers,dragana

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9d5dd0d2ecaa