1745878 - Some CSS animations have flashing black stripes

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[nayinain]

Attachment: testcase.htm

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:97.0) Gecko/20100101 Firefox/97.0

Steps to reproduce:

1. Open the testcase.html.

Actual results:

Flashing black stripes appear.

Expected results:

---

Sorry for my bad English.

Comment 1

[nayinain]

Attachment: Capture.gif

Regression window :

2021-12-14T14:07:25.033000: INFO : application_version: 96.0a1
2021-12-14T14:07:25.033000: INFO : platform_buildid: 20211125205853
2021-12-14T14:07:25.033000: INFO : platform_changeset: 68ad8a7fd3cc9ddcd32b346a9a572b9390470c82
2021-12-14T14:07:25.033000: INFO : platform_repository: https://hg.mozilla.org/integration/autoland
2021-12-14T14:07:25.033000: INFO : platform_version: 96.0a1
2021-12-14T14:07:38.932000: INFO : Narrowed integration regression window from [aac57050, 65de433d] (3 builds) to [68ad8a7f, 65de433d] (2 builds) (~1 steps left)
2021-12-14T14:07:38.939000: DEBUG : Starting merge handling...
2021-12-14T14:07:38.939000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=65de433d5d7571b19f0f60fba3c11a44de74f6c2&full=1
2021-12-14T14:07:38.939000: DEBUG : redo: attempt 1/3
2021-12-14T14:07:38.939000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/integration/autoland/json-pushes?changeset=65de433d5d7571b19f0f60fba3c11a44de74f6c2&full=1',), kwargs: {}, attempt #1
2021-12-14T14:07:38.942000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2021-12-14T14:07:40.917000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /integration/autoland/json-pushes?changeset=65de433d5d7571b19f0f60fba3c11a44de74f6c2&full=1 HTTP/1.1" 200 None
2021-12-14T14:07:40.949000: DEBUG : Found commit message:
Bug 1742742 - Use backdrop candidates for opaque picture detection r=gfx-reviewers,nical

The opaque_rect in SurfaceInfo is used to ...

Differential Revision: https://phabricator.services.mozilla.com/D132000

2021-12-14T14:07:40.950000: DEBUG : Did not find a branch, checking all integration branches
2021-12-14T14:07:40.950000: INFO : The bisection is done.
2021-12-14T14:07:40.950000: INFO : Stopped

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1742742

Comment 3

[Darkspirit]

Thanks for the report!
It does not seem to occur on Linux (and I haven't tested Win10).
Please open about:support in Nightly, click on "Copy text to clipboard" and paste it here. Thanks!
Can it be fixed by setting gfx.webrender.compositor to false on about:config and restarting Nightly?

Comment 4

[Dianna Smith [:diannaS]]

Glenn, can you take a look at this? Is this something we need to fix based on it being regressed by bug 1742742 in 96?

Comment 5

[nayinain]

Attachment: aboutSupport.txt

Setting gfx.webrender.compositor to false did not fix this issue.

Comment 6

[Glenn Watson [:gw]]

Attachment: Bug 1745878 - Temporary fix for incorrect surface opaqueness test.

Revert "Bug 1742742 - Use backdrop candidates for opaque picture detection r=gfx-reviewers,nical"

This reverts commit 6d918f342ae9dedaed4b411efe7998342f00fcf3.

The patch above can incorrectly determine a surface to be opaque
when it may not be, due to a child picture surface having a rect
that extends outside the parent estimate picture rect. The problem
is not the patch itself, but that it exposes an existing bug with
how bounding rects of child surfaces are handled.

I'm currently refactoring the visibility pass to fix how child
bounding rect propagation and inflation works. Because of this,
it's simpler to revert this change for now, and re-land once the
rest of the visibility pass work is complete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2001eb97ffe6
Temporary fix for incorrect surface opaqueness test. r=gfx-reviewers,nical

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/2001eb97ffe6

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gw, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9255610 [details]
Bug 1745878 - Temporary fix for incorrect surface opaqueness test.

Beta/Release Uplift Approval Request

• User impact if declined: Some content will render wrong because we determine opaqueness incorrectly.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is reverting 6d918f342ae9dedaed4b411efe7998342f00fcf3
• String changes made/needed:

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9255610 [details]
Bug 1745878 - Temporary fix for incorrect surface opaqueness test.

Originally approved for 96.0b9 but looks like this is dependent on bug 1743957 code(graft causes conflicts). We need that dependency to be solved before this can be uplifted and tomorrow is the last day for uplifts. Feel free to NI me if the rev is updated with a rebased patch.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

I'm not sure if we want to take the dependency. So maybe the best thing to do is nothing?

Comment 13

[Dianna Smith [:diannaS]]

:jrmuizel I agree. I think it will just go out together in 97.

Comment 14

[Monica Chiorean]

I was able to reproduce the issue on Win10x64 using NB 97.0a1 (2021-12-13).
Verified as fixed on Win10x64 and Ubuntu 20.4, using Beta 97.0b3 (20220113185849).