1745956 - [wpt-sync] Sync PR 32017 - [LayoutNG] Don't allow first tier OOF cache when fragmenting

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32017 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32017
Details from upstream follow.

Alison Maher <[e-mail]> wrote:

[LayoutNG] Don't allow first tier OOF cache when fragmenting

Caching generally doesn't work well when fragmenting, so make sure
|allow_first_tier_oof_cache_| is false when inside a fragmentation
context.

This caused an issue when setting up the OOF node to layout. We would
fail to populate |node_to_layout.offset_info.block_estimate| when the
cache was allowed, which caused a crash when trying to use the block
estimate during layout.

Bug: 1278627, 1278879
Change-Id: I69e29646c1b4d4031dd338fce4dd898dc3804a38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331522
Reviewed-by: Ian Kilpatrick \<[e-mail]>
Reviewed-by: Morten Stenshorne \<[e-mail]>
Commit-Queue: Alison Maher \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#951235}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=21101626c2832cc90eb89b459ce884dd478837a4

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/223bdf0216cc
[wpt PR 32017] - [LayoutNG] Don't allow first tier OOF cache when fragmenting, a=testonly

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/223bdf0216cc