Closed Bug 1745959 Opened 4 years ago Closed 4 years ago

getTabDialogBox should not fall back to selected browser

Categories

(Firefox :: Tabbed Browser, defect)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: emz, Assigned: emz)

Details

Attachments

(1 file)

Bug 1745959 - Do not fall back to selected browser in TabDialogBox getter. r=Gijs!
48 bytes, text/x-phabricator-request
Details | Review

Currently gBrowser.getTabDialogBox will fall back to the selected browser if no browser argument is given. This can lead to unexpected behavior. We should instead require callers to pass a browser explicitly.

https://searchfox.org/mozilla-central/rev/71befbc9bc348d33f0c7307dc48e3cb36ba78650/browser/base/content/tabbrowser.js#869

Pushed by pzuhlcke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9fd740131b2 Do not fall back to selected browser in TabDialogBox getter. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/c9fd740131b2

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: