Closed Bug 174597 Opened 23 years ago Closed 23 years ago

make palm conduit part of the installer

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P2)

Product:
SeaMonkey
Component:
MailNews: Address Book & Contacts
Platform:
x86
Windows NT
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.2beta

People

(Reporter: rdayal, Assigned: rdayal)

Details

Attachments

(1 file, 2 obsolete files)

adding the check for index to end the while loop
1.80 KB, patch
ssu0262
: review+
mscott
: superreview+
Details | Diff | Splinter Review
Palm conduit needs to be added in the installer manifest.
Instead of using GetCurrentDirectory this change uses GetModuleFileName and extracts the path out to use it for finding and loading the conduit. This enables running the Conduit Installer from a short cut even with the current dir not set to the mozilla installation dir.
Attachment #102949 - Attachment is obsolete: true
Attachment #102957 - Attachment is obsolete: true
Hi Sean, can u review this patch, thanks.
Comment on attachment 102959 [details] [diff] [review] adding the check for index to end the while loop r=ssu
Attachment #102959 - Flags: review+
Comment on attachment 102959 [details] [diff] [review] adding the check for index to end the while loop sr=mscott
Attachment #102959 - Flags: superreview+
Severity: normal → critical
Priority: -- → P2
Target Milestone: --- → mozilla1.2beta
Comment on attachment 102959 [details] [diff] [review] adding the check for index to end the while loop a=asa for checkin to 1.2 (on behalf of drivers)
This is already checked in. Marking this as fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
QA Contact: nbaca → meehansqa
Trunk build 2003-02-20: WinXP Verified Fixed. This has been fixed for awhile.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: