1746002 - [wpt-sync] Sync PR 32046 - [selectmenu] Support closed-listbox arrow keys, update input/change firing

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32046 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32046
Details from upstream follow.

Dan Clark <[e-mail]> wrote:

[selectmenu] Support closed-listbox arrow keys, update input/change firing

Allow the user to use up/down arrow keys on the \<selectmenu> button to
cycle through options when the listbox is closed.

Support firing input/change when the user changes selection in this way,
and update input/change firing behavior when listbox is open to match
the new OpenUI resolution at [1].

[1] https://github.com/openui/open-ui/issues/429

Bug: 1121840
Change-Id: I8686ad245f8d2623dec62c95dc79772519304ae7

Reviewed-on: https://chromium-review.googlesource.com/3336485
WPT-Export-Revision: 934295638d29b6ad287b40ebe9ab4dcd0f2cca9a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 32046 applied with additional changes from upstream: 81f9e818005784368e592ebd4b99b631ceee90c9, 75412ce2723fb90197e0f71b44bde04c6f60a8b8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebe854c906cb239ff2d1eaa335f9fbef5feb6f05

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
FAIL : 5

Chrome

TIMEOUT: 1
ERROR : 1
NOTRUN : 4

Safari

ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/forms/the-selectmenu-element/selectmenu-events.tentative.html
Button controller code should not run if the click event is preventDefaulted.: FAIL (Chrome: TIMEOUT)
Listbox controller code should not run if the click event is preventDefaulted.: FAIL (Chrome: NOTRUN)
<selectmenu> should fire input and change events when new option is selected: FAIL (Chrome: NOTRUN)
<selectmenu> should fire input and change events even when new selected option has the same value as the old: FAIL (Chrome: NOTRUN)
<selectmenu> should fire input and change events when option in listbox is clicked: FAIL (Chrome: NOTRUN)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/585b4c672894
[wpt PR 32046] - [selectmenu] Update input/change firing, a=testonly
https://hg.mozilla.org/integration/autoland/rev/81a5fa6e39fb
[wpt PR 32046] - Update wpt metadata, a=testonly

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/585b4c672894
https://hg.mozilla.org/mozilla-central/rev/81a5fa6e39fb