1746059 - MOZ_CRASH("todo") when ImageBitmapRenderingContext::TransferFromImageBitmap called

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

When one calls ImageBitmapRenderingContext::TransferFromImageBitmap, we try to get the ImageContainer from the OffscreenCanvas object but we explicitly crash:

https://searchfox.org/mozilla-central/rev/f465d324513f09dbe33ed79fabe6a9ef98aa51ca/dom/canvas/OffscreenCanvas.cpp#155

This just needs to hook up to OffscreenCanvas::CommitFrameToCompositor properly I think. There are relevant WPT tests that should be marked as passing once this is fixed.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1746059 - Fix broken ImageBitmapRenderingContext::TransferFromImageBitmap for OffscreenCanvas.

This patch ensures that when we call TransferFromImageBitmap, it
actually gets the correct result and resets the context to all black,
instead of just crashing. We now also clear the ImageContainer properly
instead of adding a null image if none is provided.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91c3b4249ff0
Fix broken ImageBitmapRenderingContext::TransferFromImageBitmap for OffscreenCanvas. r=lsalzman,emilio

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/91c3b4249ff0