1746114 - Collect the third-party modules ping from socket process

Status: RESOLVED FIXED

(Core :: DLL Services, enhancement)

Description

[Toshihito Kikuchi [:toshi]]

Before enabling pre-spawn CIG for socket process (bug 1743427), we collect the third-party modules ping from socket process and see what kind of modules are loaded.

Comment 1

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1746114 - Part2. Collect the third-party modules ping from socket process. r=mhowell

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7628f6c5bb8c
Collect the third-party modules ping from socket process.  r=mhowell,necko-reviewers,kershaw

Comment 3

[Marian-Vasile Laza]

Backed out changeset 7628f6c5bb8c (Bug 1746114) for causing build bustages on SocketProcessParent.obj.
Backout link
Push with failures
Failure Log
Also Mn-swr

Comment 4

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1746114 - Part1. Avoid delayloading shlwapi.dll in a sandboxed process. r=mhowell

While processing third-party module loading events, the process may delayload
shlwapi.dll. This could be a problem if the process is sandboxed and the access
to local files is restricted. Before enabling the third-party modules ping in
socket process, this patch avoids such delayloading.

The first path is ParamTraits<mozilla::ModuleRecord>::Read calls NS_NewLocalFile
that calls PathGetDriveNumberW. This API is simple enough that we define our own
version.

The second path is the ctor of ProcessedModuleLoadEvent that is called from
UntrustedModulesProcessor::CompleteProcessing calls PreparePathForTelemetry
that calls PathFindFileNameW and PathCanonicalizeW. For this path, instead
of sanitizing a requested name in ProcessedModuleLoadEvent's ctor, we sanitize
it when transferring it to the main process.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/642fde95b945
Part1. Avoid delayloading shlwapi.dll in a sandboxed process.  r=mhowell
https://hg.mozilla.org/integration/autoland/rev/7abf35bcedac
Part2. Collect the third-party modules ping from socket process.  r=mhowell,necko-reviewers,kershaw

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/642fde95b945
https://hg.mozilla.org/mozilla-central/rev/7abf35bcedac