1746140 - Add SPARC defines to third_party/libwebrtc/build/build_config.h

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P4)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

Solaris SPARC build fails with:

 4:46.34 /builds2/psumbera/mozilla-central-build/third_party/libwebrtc/build/build_config.h:201:2: error: #error Please add support for your architecture in build/build_config.h
 4:46.34   201 | #error Please add support for your architecture in build/build_config.h
 4:46.35       |  ^~~~~

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::WebRTC' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Petr Sumbera]

Attachment: Bug 1746140 - Add SPARC defines to third_party/libwebrtc/build/build_config.h

Comment 3

[Michael Froman [:mjf]]

Petr, I've locally verified that your patch doesn't cause any breakage for our normal build file generation or linux builds. Can you verify that this change fixes your build issue? Are you building with or without the --disable-webrtc flag?

Full try build test: https://treeherder.mozilla.org/jobs?repo=try&revision=687190394b95a59ffca095585afebdc85fc0c15f

Comment 4

[Petr Sumbera]

With the patch my Solaris SPARC build passed. I don't use --disable-webrtc.

Comment 5

[Michael Froman [:mjf]]

Petr, feel free to land this now that I've reviewed it. Let me know if you need me to land it for you.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65d11ae74c1e
Add SPARC defines to third_party/libwebrtc/build/build_config.h r=mjf DONTBUILD

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/65d11ae74c1e