Closed Bug 1746142 Opened 2 years ago Closed 2 years ago

Ctrl+/ keyboard shortcut does not show debugger's ShortcutsModal

Categories

(DevTools :: Debugger, defect)

defect

Tracking

(firefox97 verified)

VERIFIED FIXED
97 Branch
Tracking Status
firefox97 --- verified

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

Attachments

(1 file)

On OSX, Cmd+/ does work
This is because the event listener is using Cmd and not CmdOrCtrl (https://searchfox.org/mozilla-central/rev/dc323d0d9a3b722ca8ff0d1b2b752e5bd00dab9b/devtools/client/debugger/src/components/App.js#92)

Assignee: nobody → nchevobbe

The keyboard shortcut was not set properly (and wasn't unset).
A test is added to ensure this works as expected.

I just tested Ctrl+/ on Win10 and it doesn't seem to work for me (it's weird I'd swear it worked before)
In any case the patch fixes it.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63a6dffa7c52
[devtools] Fix keyboard shortcut for showing ShortcutsModal on non-OSX OSes. r=ochameau.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
QA Whiteboard: [qa-97b-p2]

Reproduced this issue on Windows 10 x64 using an affected Nightly build 97.0a1 (20211214094205).

Verified fixed on latest beta 97.0b9 (20220127193706), across platforms: Win 10 x64, macOS 10.14 and Ubuntu 21.04.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: