1746142 - Ctrl+/ keyboard shortcut does not show debugger's ShortcutsModal

Status: VERIFIED FIXED

(DevTools :: Debugger, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

On OSX, Cmd+/ does work
This is because the event listener is using Cmd and not CmdOrCtrl (https://searchfox.org/mozilla-central/rev/dc323d0d9a3b722ca8ff0d1b2b752e5bd00dab9b/devtools/client/debugger/src/components/App.js#92)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1746142 - [devtools] Fix keyboard shortcut for showing ShortcutsModal on non-OSX OSes. r=ochameau.

The keyboard shortcut was not set properly (and wasn't unset).
A test is added to ensure this works as expected.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I just tested Ctrl+/ on Win10 and it doesn't seem to work for me (it's weird I'd swear it worked before)
In any case the patch fixes it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63a6dffa7c52
[devtools] Fix keyboard shortcut for showing ShortcutsModal on non-OSX OSes. r=ochameau.

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/63a6dffa7c52

Comment 5

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on Windows 10 x64 using an affected Nightly build 97.0a1 (20211214094205).

Verified fixed on latest beta 97.0b9 (20220127193706), across platforms: Win 10 x64, macOS 10.14 and Ubuntu 21.04.