174619 - Installed-chrome.txt in MFCEmbed is incorrect file

Status: VERIFIED FIXED

(Core Graveyard :: Installer: MFCEmbed, defect)

Description

[Charles Rosendahl]

The Installed-chrome.txt file that is currently packaged as part of the mfcembed
(GRE version) installer is the wrong one.

The correct file is the same as the installed-chrome.txt file found in the
10-11-2002 builds.

Comment 1

[Chak Nanga]

Upping severity and setting Target Milestone.

Comment 2

[Curt Patrick (gone)]

Attachment: Patch 1

I was most certainly getting the file from the wrong place.

Comment 3

[Curt Patrick (gone)]

I'm going to need Aki to add the following two lines to the appropriate place in
build-verification.pl also:

+    &genericlog ("$ENV{MOZ_SRC}\\mozilla\\xpinstall\\packager\\pkgcp.pl
--source $ENV{MOZ_SRC}\\mozilla\\dist\\gre_app_support --destination
$ENV{MOZ_SRC}\\stage\\mfcembed --file
$ENV{MOZ_SRC}\\mozilla\\xpinstall\\packager\\pkgs2-mfcembed-win --os dos
--verbose \n");
+    system ("$ENV{MOZ_SRC}\\mozilla\\xpinstall\\packager\\pkgcp.pl --source
$ENV{MOZ_SRC}\\mozilla\\dist\\gre_app_support --destination
$ENV{MOZ_SRC}\\stage\\mfcembed --file
$ENV{MOZ_SRC}\\mozilla\\xpinstall\\packager\\pkgs2-mfcembed-win --os dos
--verbose 2>&1 ") &&

Comment 4

[Aki Sasaki]

r=asasaki
do you have write access to the ns tree?
ns/build/windows/verification/build-verification.pl
i can update the build machine once you check in.

Comment 5

[Curt Patrick (gone)]

Attachment: build-verification.pl patch 1

Sure.  I just don't usually mess with your build files.  Let me get an sr=,
then I'll check my stuff in tomorrow and you can apply this patch to the build
machine, too.  Thanks.

Comment 6

[Daniel (Leaf) Nunes]

Comment on attachment 102991 [details] [diff] [review]
Patch 1

sr=leaf, just change the silly new filename

Comment 7

[Daniel (Leaf) Nunes]

Comment on attachment 103011 [details] [diff] [review]
build-verification.pl patch 1

sr=leaf, likewise, change the reference to the silly newfilename

Comment 8

[Curt Patrick (gone)]

I checked in both patches.  Reassigning to Aki so he can close it after updating
the build machine and doing a test run.

Comment 9

[Aki Sasaki]

looks like it worked.  i'm using the 2002-10-16-17-trunk build, but y'all should
see it in tomorrow morning's builds as well.

Comment 10

[Charles Rosendahl]

Verified - 20021017 build