1746303 - browser_jsonview_expand_collapse.js test is wrong

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect, P2)

Description

[Oriol Brufau [:Oriol]]

The test checks

  ok(
    document.querySelector(selector) == null,
    "The Expand All button must be gone"
  );

But, since bug 1561362, it's never supposed to be gone!
The test is falsely passing though, because that code doesn't run in the content.

Comment 1

[Oriol Brufau [:Oriol]]

https://searchfox.org/mozilla-central/rev/667224045f6e624ac4e730171c75c21945f1b336/devtools/client/jsonview/test/browser_jsonview_expand_collapse.js#43-46

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for working on this, Oriol!

Comment 3

[Oriol Brufau [:Oriol]]

Attachment: Bug 1746303 - Fix browser_jsonview_expand_collapse.js test. r?Honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9125673abba7
Fix browser_jsonview_expand_collapse.js test. r=Honza

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9125673abba7