1746311 - [wpt-sync] Sync PR 32100 - [GridFragmentation] Fix crash with indefinite forced breaks.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32100 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32100
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[GridFragmentation] Fix crash with indefinite forced breaks.

Previously within ShiftBreakpointIntoNextFragmentainer we'd always
assume the fragmentainer_space was definite.

Inside the initial column balancing pass this is incorrect. For this
case we set the fragmentainer_space to the row breakpoint such that
we'll position the items in the correct fragmentainer.

Added test grid-item-fragmentation-039 which would trigger the crash.
However this doesn't solve the issue as we are reporting an incorrect
block-size.

Bug: 614667
Change-Id: I155d744f92744e1196c70fb17179e3e2324fe63a

Reviewed-on: https://chromium-review.googlesource.com/3343453
WPT-Export-Revision: 0e1861c454695b18f5698f7d8c14d638948a4d6e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b359c07ff5050da18c1e1f5255d16efa8ed5ac6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-break/grid/grid-item-fragmentation-039.html: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7cba7348a39
[wpt PR 32100] - [GridFragmentation] Fix crash with indefinite forced breaks., a=testonly
https://hg.mozilla.org/integration/autoland/rev/7dff03a3ead8
[wpt PR 32100] - Update wpt metadata, a=testonly

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e7cba7348a39
https://hg.mozilla.org/mozilla-central/rev/7dff03a3ead8