1746323 - Missing lock in PromiseWorkerProxy::Create()

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

We should be locking before calling CleanupProperties() in the error case where a worker is in mid-shutdown when we try to call PromiseWorkerProxy::Create()

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1746323: PromiseWorkerProxy cleanup r=smaug

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

There doesn't seem to be any actual issue here, since the lock is missing from case when the ::Create method fails and nothing has been posted to another thread.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

I removed sec-moderate, since I can't see what a concrete security issue could be here.
Add it back if I missed something :)

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

PromiseWorkerProxy cleanup r=smaug
https://hg.mozilla.org/integration/autoland/rev/5d3d5ff52f415d01eb30726836153fa359c0ed20
https://hg.mozilla.org/mozilla-central/rev/5d3d5ff52f41

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Per IRL discussion with Randell, this is mostly cleanup and not likely affecting us in the wild in a way which would make us want to backport.