1746376 - Credit Card Save doorhanger is displayed twice when choosing not to save

Status: NEW

(Toolkit :: Form Autofill, defect, P3)

Description

[Simona Badau, Desktop QA]

Affected Versions:

All latest Firefox versions: Nightly 97.0a1, Beta 96, Release 95

Tested on:

MacOS 11.6
Windows 10

Preconditions:

browser.search.region UK
extensions.formautofill.supportedCountries UK
download latest Firefox Nightly with region locale (switch extensions.formautofill.available to "on" for testing non-Nightly builds)

Steps to reproduce:

1. Login to https://www.amazon.co.uk
2. Add an item to the basket and reach the payment form
3. Fill in manually new CC info and submit the form
4. When the CC Save doorhanger is displayed, click on "Don't Save".

Expected Results:

The CC Save Doorhangher should be dismissed.

Actual Results:

CC Save Doorhanger is dismissed but triggered again afterward. Please see the screencast for more details

Notes:

Severity: S4 severity.
Reproducible on Chrome: No

Affected sites:

amazon.co.uk, amazon.de, amazon.fr
tesco.com
next.co.uk

Comment 1

[Dimi Lee [:dimi]]

This first doorhanger is triggered by form submission event.
This second doorhanger is triggered by pagehide event.

Right now, in FormAutofill formSubmitted function, we don't check whether there is already a form submitted with the same credit card information. To address this issue, we may want to check if we have seen the values before like what we do in the password manager .

This issue will become more important if we add more form submission event heuristics in the future (for example, form removal, page navigation).

Comment 2

[Simona Badau, Desktop QA]

I stumbled upon two more scenarios that trigger the CC doorhanger unexpectedly:

1. Hitting the Back button after entering the Card number - reproduced it on https://www.argos.co.uk - here is a screencast

2. Dismissing the Add credit info dialog by clicking outside of it and returning back to it on https://www.amazon.co.uk - here is a screencast

Dimi, could these 2 scenarios have the same cause, or should I file new bugs for them?

Comment 3

[Dimi Lee [:dimi]]

(In reply to Simona Badau from comment #2)

Dimi, could these 2 scenarios have the same cause, or should I file new bugs for them?

Yes, it looks like both the two cases have the same root cause as this one.
I think we can just use this bug to track related issues.