1746457 - Requesting data review for Mozilla VPN client: Technical IAP data

Status: RESOLVED FIXED

(Mozilla VPN :: General, task)

Description

[Sebastian Streich [:sstreich]]

The current publicly available list of collected events can be found here:
mozilla-mobile/mozilla-vpn-client/blob/main/glean/metrics.yaml

The events that are about to be added can be found here:
mozilla-mobile/mozilla-vpn-client/#2262

Comment 1

[Sebastian Streich [:sstreich]]

Attachment: Data Review Request

Comment 2

[Chris H-C :chutten]

Comment on attachment 9255762 [details]
Data Review Request

PRELIMINARY NOTES:
As the Mozilla VPN Client is using Glean, its documentation is provided here: https://dictionary.telemetry.mozilla.org/apps/mozilla_vpn

Also, you can use the glean_parser command data-review to generate a skeleton data review with the easy parts already filled out for you, if you'd like.

DATA REVIEW RESPONSE:
data-review- for a permanent collection without a responsible individual listed. Please resubmit with the answer to Q7 including the responsible individual's name.

Comment 3

[Sebastian Streich [:sstreich]]

Attachment: Data Review Request v2

Hello! Thanks for the feedback, i re-generated the request using the glean helper and added the answer for question 7. Could you have a look again? :)

Comment 4

[Chris H-C :chutten]

Comment on attachment 9257512 [details]
Data Review Request v2

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Sebastian Streich is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 5

[Chris H-C :chutten]

While I'm here, I couldn't help noticing that all the categories are sample and all the names start with iap_g_. Is sample meaningful or just a catch-all? To me it seems as though the category could be iap.g instead (or sample.iap.g if the word sample is meaningful). (( you could also have categories named iap.g.purchases and iap.g.query and so forth if you want finer-grained categorization. Categories aim to be useful organizational tools the Glean SDK provides to projects. ))

(( glean_parser actually has a linter that could've caught this it if checked subsets of categories and not complete categories. Whoops : ) ))

This is me stepping out of my lane as a Data Steward and into being an opinionated member of the Glean Team, though, so feel free to ignore this part. How a project names its metrics is (outside of glean_parser nits and reserved keywords) its own business.

Comment 6

[Sebastian Streich [:sstreich]]

Currently, just a catch-all, as our tooling to generate the qt-bindings does not support that yet. I really like that idea, as it would make very much now make sense to group it that way. Time to update the that tooling :)
Thank you!