1746466 - a=maxptime is handled inappropriately by JSEP negotiation code

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P3)

Description

[Byron Campen [:bwc]]

It looks like we're using a=maxptime to init the initial frame size, not the maximum frame size, here:

https://searchfox.org/mozilla-central/rev/ead7da2d9c5400bc7034ff3f06a030531bd7e5b9/dom/media/webrtc/jsep/JsepCodecDescription.h#242

This just looks like a typo. I don't know if there's anything in the field that is actually using a=maxptime; neither Chrome nor Firefox seems to by default. However, this is a pretty easy fix.

Comment 1

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=95107a5371b7b3dd371f01062338c1aceee9cacd
https://treeherder.mozilla.org/#/jobs?repo=try&revision=35d2c6afb1e76ffdc4ab20625a187909b4d74efa

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1746466: Fix a typo that was causing a=maxptime to be handled incorrectly. r?ng

Comment 3

[Byron Campen [:bwc]]

Try looks good.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/083a78cf68a3
Fix a typo that was causing a=maxptime to be handled incorrectly. r=ng

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/083a78cf68a3