Closed Bug 1746479 Opened 2 years ago Closed 11 months ago

Clean up locking in TaskController

Categories

(Core :: XPCOM, defect)

defect

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox-esr102 --- wontfix
firefox111 --- wontfix
firefox112 --- wontfix
firefox113 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

(Blocks 1 open bug)

Details

(Keywords: sec-audit, sec-moderate, Whiteboard: [post-critsmash-triage][adv-main113+r])

Attachments

(1 file)

Cleans up locking in TaskController and fixes several issues found with Clang thread-safety. (Note that the annotations will land later - GUARDED_BY/etc).

In particular the handling of mPoolThreads seems like it needs to be locked, plus a few others.

Assignee: nobody → rjesup
Status: NEW → ASSIGNED
Group: core-security → dom-core-security

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jesup, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(rjesup)
Flags: needinfo?(bas)

Don't think there's anything for me to do here.

Flags: needinfo?(bas)
Flags: needinfo?(rjesup)

Should the patch land or what?

Flags: needinfo?(rjesup)
Flags: needinfo?(rjesup)
Group: dom-core-security → core-security-release
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Flags: qe-verify-
Whiteboard: [post-critsmash-triage]
Whiteboard: [post-critsmash-triage] → [post-critsmash-triage][adv-main113-]
Whiteboard: [post-critsmash-triage][adv-main113-] → [post-critsmash-triage][adv-main113+r]
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.