Closed
Bug 1746479
Opened 4 years ago
Closed 2 years ago
Clean up locking in TaskController
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
113 Branch
People
(Reporter: jesup, Assigned: jesup)
References
(Blocks 1 open bug)
Details
(Keywords: sec-audit, sec-moderate, Whiteboard: [post-critsmash-triage][adv-main113+r])
Attachments
(1 file)
Cleans up locking in TaskController and fixes several issues found with Clang thread-safety. (Note that the annotations will land later - GUARDED_BY/etc).
In particular the handling of mPoolThreads seems like it needs to be locked, plus a few others.
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Assignee: nobody → rjesup
Status: NEW → ASSIGNED
Updated•4 years ago
|
Group: core-security → dom-core-security
Comment 2•3 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jesup, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.
Flags: needinfo?(rjesup)
Flags: needinfo?(bas)
Assignee | ||
Updated•3 years ago
|
Flags: needinfo?(rjesup)
Assignee | ||
Updated•2 years ago
|
Flags: needinfo?(rjesup)
![]() |
||
Comment 5•2 years ago
|
||
xpcom TaskController cleanup r=bas
https://hg.mozilla.org/integration/autoland/rev/2ea1174827597a306f67ef69969911256da1e094
https://hg.mozilla.org/mozilla-central/rev/2ea117482759
Group: dom-core-security → core-security-release
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox113:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Updated•2 years ago
|
status-firefox111:
--- → wontfix
status-firefox112:
--- → wontfix
status-firefox-esr102:
--- → wontfix
Updated•2 years ago
|
Flags: qe-verify-
Whiteboard: [post-critsmash-triage]
Updated•2 years ago
|
Whiteboard: [post-critsmash-triage] → [post-critsmash-triage][adv-main113-]
Updated•2 years ago
|
Whiteboard: [post-critsmash-triage][adv-main113-] → [post-critsmash-triage][adv-main113+r]
Updated•2 years ago
|
Group: core-security-release
You need to log in
before you can comment on or make changes to this bug.
Description
•