Closed Bug 1746516 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 32119 - [css-pseudo] Add support for text-decoration in highlight pseudos

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32119 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32119
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:

[css-pseudo] Add support for text-decoration in highlight pseudos

This patch adds support for adding text-decoration on highlight pseudos
::highlight and ::target-text.

To do this, it exposes HighlightPaintingUtils::HighlightPseudoStyle()
so we can use it from NGHighlightPainter::Paint().
There we use NGTextDecorationPainter to paint the text decorations
defined by the highlight pseudo.

BUG=1274174

TEST=external/wpt/css/css-highlight-api/painting/custom-highlight-painting-text-decoration-001.html
TEST=external/wpt/css/css-highlight-api/painting/custom-highlight-painting-text-decoration-dynamic-001.html
TEST=external/wpt/css/css-pseudo/target-text-text-decoration-001.html

Change-Id: I9731fd7dbef938a8470d190310d20612d95e72b8

Reviewed-on: https://chromium-review.googlesource.com/3344847
WPT-Export-Revision: 4ef5cd84769977144bf4f0307b91574bc7602e9b

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

FAIL : 1
TIMEOUT: 2

Chrome

PASS : 1
FAIL : 2

Safari

PASS : 2
TIMEOUT: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-highlight-api/painting/custom-highlight-painting-text-decoration-001.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-highlight-api/painting/custom-highlight-painting-text-decoration-dynamic-001.html: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/css/css-pseudo/target-text-text-decoration-001.html: TIMEOUT (Chrome: FAIL, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c5367d96184
[wpt PR 32119] - [css-pseudo] Add support for text-decoration in highlight pseudos, a=testonly
https://hg.mozilla.org/integration/autoland/rev/1c508aa79566
[wpt PR 32119] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/0c5367d96184
https://hg.mozilla.org/mozilla-central/rev/1c508aa79566

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.