1746536 - Add nsTSubstring<T>::* to the prefix signature list

Status: RESOLVED FIXED

(Socorro :: Signature, task, P2)

Description

[Andrew McCreight [:mccr8]]

There are various other nsTSubstring functions in the prefix list, but apparently not Truncate. It might be a good idea to just consolidate all of the nsTSubstring<T>:: things into nsTSubstring<T>::* or something like that.

Right now there's nsTSubstring<.*>::Assign and nsTSubstring<T>::Append, but I think we probably want all of these functions in this class prefixed. I'm not sure what the best way to write that.

See bug 1746416 for an example. Here's an example report from that bug: bp-b0272f60-7b6c-4b96-9496-c73430211216

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

To clarify, right now the prefix list has these items:

nsTSubstring<T>::Append
nsTSubstring<.*>::Assign

This bug posits that instead of specifying all the functions in nsTSubstring individually, we should add an entry covering all of them.

Thus we should remove those two and add something like:

nsTSubstring<.*>::

A cursory look at signatures in Crash Stats suggests this will pick up the following functions:

• Append
• Assign
• SetLength
• Split
• StartBulkWriteImpl
• Truncate
• Finalize

Does that plan sound right?

Comment 2

[Andrew McCreight [:mccr8]]

Sounds good, thanks.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6087: bug 1746536: add all nsTSubstring functions to prefix list

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6087: "bug 1746536: add all nsTSubstring functions to prefix list" in 96cf6c1.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

I pushed this to prod just now in bug #1769264. Marking as FIXED.