Closed Bug 1746683 Opened 11 months ago Closed 11 months ago

Add hwb/hwba to devtools autocomplete lists.

Categories

(DevTools :: Inspector: Rules, task)

task

Tracking

(firefox97 fixed)

RESOLVED FIXED
97 Branch
Tracking Status
firefox97 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(2 files)

Thank you for helping make Firefox better. If you are reporting a defect, please complete the following:

What were you doing?

Please tell us what site you were on, and what steps led to the error you are reporting

  1. First step
  2. Second step

What happened?

What, if any, error messages did you see? Did the browser crash? Screenshots or screen recordings can be attached to this report and are helpful in isolating and replicating the bug.

What should have happened?

Was was the expected result? ("Not crashing" may be a valid answer.)

Anything else we should know?

Do you have extensions installed? You can also go to about:support in another window or tab and attach the report it generates to this bug.

Attachment #9255980 - Attachment description: Bug 1746683 - Add hbw/a to devtools autocomplete lists. r=jdescottes,#layout-reviewers → Bug 1746683 - Add hwb/a to devtools autocomplete lists. r=jdescottes,#layout-reviewers
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9782fd301cc
Add hwb/a to devtools autocomplete lists. r=dholbert

Backed out for causing mochitest failures in layout/inspector/tests/test_bug877690.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/0978a49f760a6618d883efc621c36673a0720e2a

Push with failures

Failure log

 INFO - TEST-START | layout/inspector/tests/test_bug877690.html
[task 2021-12-18T03:55:09.190Z] 03:55:09     INFO - TEST-INFO | started process screentopng
[task 2021-12-18T03:55:09.429Z] 03:55:09     INFO - TEST-INFO | screentopng: exit 0
[task 2021-12-18T03:55:09.432Z] 03:55:09     INFO - TEST-UNEXPECTED-FAIL | layout/inspector/tests/test_bug877690.html | property color's values. 
[task 2021-12-18T03:55:09.433Z] 03:55:09     INFO -     SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2021-12-18T03:55:09.434Z] 03:55:09     INFO -     do_test@layout/inspector/tests/test_bug877690.html:58:5
[task 2021-12-18T03:55:09.434Z] 03:55:09     INFO -     callStackHandler@SimpleTest/SimpleTest.js:279:24
[task 2021-12-18T03:55:09.434Z] 03:55:09     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-12-18T03:55:09.434Z] 03:55:09     INFO - TEST-UNEXPECTED-FAIL | layout/inspector/tests/test_bug877690.html | property background values.
Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6e5b1672f3b
Add hwb/a to devtools autocomplete lists. r=dholbert
Summary: Add hbw/hbwa to devtools autocomplete lists. → Add hwb/hwba to devtools autocomplete lists.
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch

Emilio, please note that there is no hwba() function! It's just hwb().

Sebastian

Flags: needinfo?(emilio)

D'oh!

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)

Partially backs out the previous patch.

Status: RESOLVED → REOPENED
Flags: needinfo?(emilio)
Resolution: FIXED → ---
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6116ecc7b1c
Remove hwba since it's not a thing (hwb function supports alpha).
Status: REOPENED → RESOLVED
Closed: 11 months ago11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.