Closed Bug 1746685 Opened 2 years ago Closed 2 years ago

Eyedropper has poor contrast on pages that use `<meta name=color-scheme content=dark>` or equivalent

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox97 fixed)

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

Bug 1746685 - Fix eye dropper contrast on dark pages. r=jdescottes,nchevobbe
48 bytes, text/x-phabricator-request
Details | Review

https://searchfox.org/mozilla-central/rev/fecb1af272051b0fc2346647b1a3193609744384/devtools/server/actors/highlighters.css#544 only specifies a background color and doesn't specify a foreground color, so in dark mode the foreground is light, which is not readable. Both bugzilla and searchfox in dark mode show this issue.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11bcd7ebb2bd
Fix eye dropper contrast on dark pages. r=jdescottes

https://hg.mozilla.org/mozilla-central/rev/11bcd7ebb2bd

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: