1746709 - Use `ChromeUtils.import` with one parameter in test_GMPInstallManager.js

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P5)

Description

[Mathew Hodson]

Passing a scope or null as the second argument to ChromeUtils.import(..., null) causes behaviour that we don't want now. As we look towards a new module system we need to prevent this behaviour.

In https://phabricator.services.mozilla.com/D127387, @robwu wrote:

There is another user of computeHash, at https://searchfox.org/mozilla-central/rev/1dab956095020c53aa66cbee8845eb1fa925b75c/toolkit/modules/tests/xpcshell/test_GMPInstallManager.js#537

The scope is also used to override the createXHR method. You could also get rid of that use by introducing a new method that takes the xhr parameter as input, to replace the XHR method:

• https://searchfox.org/mozilla-central/rev/1dab956095020c53aa66cbee8845eb1fa925b75c/toolkit/modules/tests/xpcshell/test_GMPInstallManager.js#982-994
• https://searchfox.org/mozilla-central/rev/1dab956095020c53aa66cbee8845eb1fa925b75c/toolkit/mozapps/extensions/internal/ProductAddonChecker.jsm#22-26

Comment 1

[Mathew Hodson]

Attachment: Bug 1746709 - Use `ChromeUtils.import` with one parameter in test_GMPInstallManager.js. r?robwu

Export new ProductAddonCheckerTestUtils for methods only used by
tests.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ea2d48172e1
Use `ChromeUtils.import` with one parameter in test_GMPInstallManager.js. r=robwu

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/8ea2d48172e1